Conversation
Contributor
Eugene-hu
commented
Jul 10, 2023
Eugene-hu
commented
- validator was missing a check for the diversity model when there are no competitions
shibshib
approved these changes
Jul 10, 2023
p-ferreira
approved these changes
Jul 10, 2023
Contributor
p-ferreira
left a comment
p-ferreira
left a comment
There was a problem hiding this comment.
LGTM! Are we planning to release this ASAP or can it wait? Asking this to understand if this will be released as a new version to be released now (merge direct into main) or if it will be part of the next release (merge direct into staging)
isabella618033
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.