Merged
Conversation
shibshib
approved these changes
Jul 11, 2023
isabella618033
approved these changes
Jul 11, 2023
| if model_name is not None: | ||
| config.gating.model_name = model_name | ||
| config.gating.num_uids = num_uids if num_uids is not None else metagraph.n | ||
| config.gating.num_uids = num_uids if num_uids is not None else config.gating.num_uids |
Contributor
There was a problem hiding this comment.
how would we handle it when the gating.num_uids is < or > metagraph.n ?
Contributor
Author
There was a problem hiding this comment.
Generally, we should set the gating.num_uids to be greater than metagraph.n. That way the gating model will have enough embeddings in its linear layer for any increases in uids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--gating.num_uidswas set as metagraph.n instead of the command line value