fix: save button red dot shows exception

[SonyLeo]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

添加元素后执行撤回操作，保存按钮右上角红点未消失

【复现步骤】1、页面添加元素后不刷新； 2、再添加一个元素并撤回，保存按钮右上角红点不消失

【问题分析】保存代码后，未将最新的 Schema 信息同步至 toolbar/save 中的相关逻辑，导致标记显示异常

【过程截图】如下所示

Issue Number: N/A

What is the new behavior?

添加元素后执行撤回操作，保存按钮右上角红点正常消失

【过程截图】如下所示

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features
  • The page update process now sends notifications to alert when content changes occur. This enhancement helps ensure updates are communicated more efficiently across the system.

[coderabbitai]

Walkthrough

The pull request updates the handlePageUpdate function in packages/common/js/http.js by changing its import and logic. The import is modified to use useMessage instead of useCanvas. In the function, the previous extraction of setSaved and its subsequent call has been removed, and a new call to useMessage().publish is added to send a schema change notification with the page content. No changes were made to the exported or public entities.

Changes

File(s)	Change Summary
packages/common/js/http.js	Updated import: Removed useCanvas and added useMessage. Modified handlePageUpdate: removed setSaved destructuring and call, added useMessage().publish call to send a schema change notification.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Page Update Trigger
    participant Handler as handlePageUpdate
    participant Msg as useMessage

    Client->>Handler: Trigger page update
    Handler->>Msg: Call publish(topic, pageContent)
    Msg-->>Handler: Notification published

Loading

Possibly related PRs

• fix: undo or reply to save button tag display logic optimization #1185: Involves shifting state management from setSaved to a messaging notification system.
• fix: optimize block code saving and publishing logic #996: Alters page update logic by changing the handling of setSaved in a different context, making it related to the current changes.

Suggested labels

bug

Suggested reviewers

• hexqi
• chilingling

Poem

I'm a hopping rabbit in the code field bright,
Out with the old setSaved, in with the messaging light.
I twirl in the syntax, with a joyful little hop,
Publishing schema updates till the bugs all stop.
With a twitch of my ears and a playful little cheer,
CodeRabbit sings—our refactor is here! 🐰

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f912d39 and a4b56a7.

📒 Files selected for processing (1)

• packages/common/js/http.js (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: push-check

🔇 Additional comments (2)

packages/common/js/http.js (2)

15-15: Good architecture change: Updated import to support messaging pattern

The import has been updated to include useMessage instead of the previously used useCanvas. This change supports the architectural shift from direct state management to a pub/sub messaging pattern, which is more maintainable and provides better decoupling between components.

---

65-69: Excellent fix for the save button red dot issue

The previous implementation directly set the saved state through setSaved(true), which wasn't properly synchronizing with the schema after undo operations. By replacing it with a message publication system, you're ensuring that all components (including the save button indicator) will receive updates about schema changes.

This messaging approach properly addresses the issue where the red dot indicator wasn't disappearing after an undo operation, as described in the PR objectives.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.