Skip to content

fix:My application ID transmission issue#1771

Merged
hexqi merged 1 commit intoopentiny:release/v2.10.xfrom
lichunn:fix/model-bug
Feb 13, 2026
Merged

fix:My application ID transmission issue#1771
hexqi merged 1 commit intoopentiny:release/v2.10.xfrom
lichunn:fix/model-bug

Conversation

@lichunn
Copy link
Copy Markdown
Collaborator

@lichunn lichunn commented Feb 13, 2026

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Bug Fixes
    • Fixed application list filtering to use the current user's identifier instead of a hardcoded value.

@github-actions github-actions Bot added bug Something isn't working release merge to release/ branch, before release period labels Feb 13, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 13, 2026

Walkthrough

The pull request updates Main.vue to retrieve the current user's ID from a meta service API and use it for filtering applications by creator, replacing a previously hardcoded value. This change ties application filtering to the authenticated user's identity.

Changes

Cohort / File(s) Summary
User Identity Integration
packages/workspace/application-center/src/Main.vue
Added getMetaApi and META_SERVICE imports. In setup, getUserInfo is retrieved from the meta service. The createdBy filter now uses the current user's ID (via getUserInfo()) instead of a hardcoded '1' when the filter is not 'all', providing user-specific application filtering.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit's delight, the hardcoded "one" has fled! 🐰
Now filters flow with the user's true head,
No more mystery numbers in sight,
Just identity fresh, pure, and right! 🎯✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: My application ID transmission issue' directly relates to the changeset, which updates the createdBy field to use the current user's ID instead of a hardcoded value for non-'all' application filters.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into release/v2.10.x

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@packages/workspace/application-center/src/Main.vue`:
- Around line 169-176: The getApplicationList function constructs
params.currentPage/pageSize/name/createdBy using getUserInfo(); update the
createdBy assignment to safely read the id using optional chaining (e.g., use
info?.id) so that when the user object lacks an id the code doesn't throw;
locate getApplicationList and the getUserInfo call and replace direct access to
info.id with a guarded access (info?.id) while keeping the existing logic that
sets createdBy to '' when state.appFilter === 'all'.

Comment thread packages/workspace/application-center/src/Main.vue
@hexqi hexqi merged commit 19f6fa1 into opentiny:release/v2.10.x Feb 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working release merge to release/ branch, before release period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants