Skip to content

fix(err-monitor): stop monitoring if monitorurl not exist #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenmine merged 2 commits into from
Apr 16, 2024
Merged

fix(err-monitor): stop monitoring if monitorurl not exist #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7376b07
fix(err-monitor): stop monitoring if monitorurl not exist
chilingling Apr 15, 2024
44c6a85
fix(error-monitor): cancel request if url not exist
chilingling Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/controller/js/http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,13 @@ const http = useHttp()
* @param { json } params {"event_type": design_error,"url": "elit in reprehenderit enim incididunt" }
* @returns { Promise }
*/
export const requestEvent = (url, params) => http.post(url, params).catch(() => {})
export const requestEvent = (url, params) => {
if (!url) {
return
}

return http.post(url, params).catch(() => {})
}

/**
* 页面更新
Expand Down
4 changes: 4 additions & 0 deletions packages/controller/js/monitor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ const promiseMonitoring = () => {
*/

export const iframeMonitoring = () => {
if (!monitorUrl) {
Comment thread
rhlin marked this conversation as resolved.
return false
}

window.frames[0].onerror = function (errorMessage, scriptURI, lineNo, columnNo, error) {
requestEvent(monitorUrl, {
event_type: 'design_iframeError',
Expand Down