feat: add vite-config package#558
Conversation
WalkthroughThe recent updates primarily enhance the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- designer-demo/package.json (1 hunks)
- designer-demo/src/main.js (1 hunks)
- designer-demo/vite.config.js (1 hunks)
- packages/build/vite-config/index.js (1 hunks)
- packages/build/vite-config/package.json (1 hunks)
- packages/build/vite-config/src/default-config.js (5 hunks)
- packages/build/vite-config/vite.config.js (1 hunks)
- packages/common/package.json (1 hunks)
- packages/design-core/package.json (1 hunks)
- packages/design-core/src/init.js (1 hunks)
Files skipped from review due to trivial changes (5)
- designer-demo/src/main.js
- packages/build/vite-config/package.json
- packages/build/vite-config/vite.config.js
- packages/common/package.json
- packages/design-core/src/init.js
Additional comments not posted (10)
packages/build/vite-config/index.js (2)
1-1: Export ofgetDefaultConfiglooks good.
2-2: Export ofmetaCommentsPluginlooks good.designer-demo/package.json (3)
14-14: Addition of@opentiny/tiny-engine-configuratorwith workspace version specifier is consistent with project standards.
15-18: Addition of@opentiny/vueand related packages with specific version constraints ensures compatibility and predictable builds.
23-23: Addition of@opentiny/tiny-engine-vite-configand@opentiny/tiny-engine-vite-plugin-meta-commentsas dev dependencies is consistent with project standards.packages/design-core/package.json (1)
17-20: Addition of"assets"to thefilesarray ensures necessary static assets are included in the package distribution.designer-demo/vite.config.js (2)
3-3: Import ofgetDefaultConfigfrom@opentiny/tiny-engine-vite-configis correctly implemented.
6-9: Enhancements todefineConfigwith additionalextOptionsforiconDirsimprove configuration flexibility and functionality.packages/build/vite-config/src/default-config.js (2)
145-145: ExtenddefineConfigto acceptextOptions.The addition of
extOptionsto thedefineConfigfunction signature allows for more flexible configuration, enabling the passing of external options which can be used in plugin configurations. This is a good practice as it enhances the modularity and scalability of the configuration setup.
229-233: IntroducecreateSvgIconsPluginwith dynamic configuration.The integration of
createSvgIconsPluginwith dynamiciconDirsconfiguration viaextOptionsis a robust enhancement. It allows for more flexible icon management in different deployment environments or build modes, which can significantly improve the maintainability and scalability of the icon setup.
* feat: add vite config package
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Chores