-
Notifications
You must be signed in to change notification settings - Fork 473
feat(registry): metapp in registry support configuration in array format #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chilingling
merged 6 commits into
opentiny:refactor/develop
from
gene9831:refactor/registry-extension
Jul 11, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
863fdcc
refactor: metapp in registry support configuration in array format
gene9831 5d3766f
feat: add unit tests for preprocessRegistry function
gene9831 9ea66e2
feat: remove array format configuration for single entry
gene9831 f4b9324
fix: remove redundant condition
gene9831 0ac3d14
fix: add check array condition
gene9831 fd79e99
Merge branch 'refactor/develop' of github.com:opentiny/tiny-engine in…
gene9831 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import { describe, expect, it } from 'vitest' | ||
| import { preprocessRegistry } from '../src/common' | ||
|
|
||
| describe('preprocessRegistry', () => { | ||
| it('should handle normal configuration without array format', () => { | ||
| const registry = { | ||
| layout: { id: 'layout1' }, | ||
| plugins: [{ id: 'plugin1' }, { id: 'plugin2' }] | ||
| } | ||
|
|
||
| preprocessRegistry(registry) | ||
|
|
||
| expect(registry).toEqual({ | ||
| layout: { id: 'layout1' }, | ||
| plugins: [{ id: 'plugin1' }, { id: 'plugin2' }] | ||
| }) | ||
| }) | ||
|
|
||
| it('should transform array format configuration for multiple entries', () => { | ||
| const registry = { | ||
| plugins: [[{ id: 'plugin1' }, { options: { extraOption1: true } }], { id: 'plugin2' }] | ||
| } | ||
|
|
||
| preprocessRegistry(registry) | ||
|
|
||
| expect(registry).toEqual({ | ||
| plugins: [ | ||
| { | ||
| id: 'plugin1', | ||
| options: { extraOption1: true } | ||
| }, | ||
| { id: 'plugin2' } | ||
| ] | ||
| }) | ||
| }) | ||
|
|
||
| it('should not transform invalid array formats', () => { | ||
| const registry = { | ||
| layout: [{ id: 'layout1' }, { id: 'layout2' }] | ||
| } | ||
|
|
||
| preprocessRegistry(registry) | ||
|
|
||
| expect(registry).toEqual({ | ||
| layout: [{ id: 'layout1' }, { id: 'layout2' }] | ||
| }) | ||
| }) | ||
|
|
||
| it('should handle empty arrays', () => { | ||
| const registry = { | ||
| layout: [] | ||
| } | ||
|
|
||
| preprocessRegistry(registry) | ||
|
|
||
| expect(registry).toEqual({ | ||
| layout: [] | ||
| }) | ||
| }) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.