This repository was archived by the owner on May 23, 2023. It is now read-only.
Clean copy of #115#127
Closed
bhs wants to merge 45 commits intoopentracing:masterfrom
Closed
Conversation
This builds on opentracing#111 and makes some improvements and changes. There are a few important changes from the approach in that previous PR (which I will leave around for comparison): 1) There is no more activate()-time parameter about finish() behavior. Instead, ActiveSpanHolder.Continuation has internal refcounting. This leads to more fluent code and fewer bugs: either from forgetting to finish(), or from not-knowing what to pass to activate(), especially in Runnable/Callable wrappers (which was a real problem in my explorations with "real" codebases). 2) Per the above, ActiveSpanHolder and ActiveSpanHolder.Continuation are abstract classes rather than pure interfaces, and thus the refcounting is actually part of OT-Java rather than OT-Java impls. 3) I also addressed some naming and minor semantic concerns from PR opentracing#111
Per PR feedback, separate out the concepts here, rename for clarity, and update examples and documentation.
Also, have ActiveSpan inherit from Span. Deal with fallout.
... via an MDC implementation.
Also, have ActiveSpan inherit from Span. Deal with fallout.
Also, update a lot of comments and README stuff.
This is now built on top of the branch that removes -impl and the SpanContex:SpanBuilder coupling.
Also, defined the behavior of multiple calls to Tracer.finish()
Contributor
|
since the merge this probably should be closed up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REVIEWERS: Feel free to look only at #115; I will keep these in lock-step until #115 merges. ... but #115 is breaking Github, and this one hopefully won't :)
cc @cwe1ss who asked for this.
PS: I am planning to manually merge back interesting discussions into #115, btw. No need to keep track of this one unless you want to.