This repository was archived by the owner on May 23, 2023. It is now read-only.
Conversation
yurishkuro
approved these changes
Sep 17, 2017
pavolloffay
reviewed
Sep 18, 2017
| * PEER_HOST_IPV4 records IPv4 host address of the peer. | ||
| */ | ||
| public static final IntTag PEER_HOST_IPV4 = new IntTag("peer.ipv4"); | ||
| public static final IntOrStringTag PEER_HOST_IPV4 = new IntOrStringTag("peer.ipv4"); |
Member
There was a problem hiding this comment.
By doing this there is not a way how to deprecate int part. Spec says that it's string https://github.com/opentracing/specification/blob/master/semantic_conventions.md.
Member
|
PR open-review-merge in 4 hours (on Sunday) does not leave any time for other people to look/review/comment. |
Member
Author
|
@pavolloffay Because this is a pr last several months... and @yurishkuro think this is a bad time to break the API, and I agree him. So, by @yurishkuro suggestion (good one), I did in this pr. Origin pr is this: #163. The discussion ends 3 days ago. I delayed my work... because of releasing skywalking 3.2 I known the spec said string, but we have released so many versions. We must consider that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am creating a new pull request for #163. It is for #162 . And taken @yurishkuro 's suggestion.