Skip to content
This repository was archived by the owner on May 23, 2023. It is now read-only.

Add a new example for Fire-and-Forget style messages.#205

Closed
carlosalberto wants to merge 1 commit intoopentracing:v0.31.0from
carlosalberto:async_fireforget_example
Closed

Add a new example for Fire-and-Forget style messages.#205
carlosalberto wants to merge 1 commit intoopentracing:v0.31.0from
carlosalberto:async_fireforget_example

Conversation

@carlosalberto
Copy link
Copy Markdown
Collaborator

@carlosalberto carlosalberto commented Oct 17, 2017

New example based on Actor System style messages, where messages can be of fire-and-forget style.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 17, 2017

Coverage Status

Coverage remained the same at 78.598% when pulling 29ae429 on carlosalberto:async_fireforget_example into cdc9601 on opentracing:v0.31.0.

@tylerbenson
Copy link
Copy Markdown

tylerbenson commented Oct 18, 2017

This is already a case that is covered in #197.

@carlosalberto
Copy link
Copy Markdown
Collaborator Author

carlosalberto commented Oct 18, 2017

It's pretty similar, yes. Maybe we should move it to an additional test case

@carlosalberto
Copy link
Copy Markdown
Collaborator Author

carlosalberto commented Jan 3, 2018

Closing this PR since, as Tyler pointed out, this is a very similar case, and even though it spots some differences, it's probably not as important/needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlosalberto @coveralls @tylerbenson