This repository was archived by the owner on May 23, 2023. It is now read-only.
Updating the Mock Tests To Use Proper Scope Manager#264
Merged
yurishkuro merged 1 commit intoopentracing:masterfrom Mar 29, 2018
Merged
Updating the Mock Tests To Use Proper Scope Manager#264yurishkuro merged 1 commit intoopentracing:masterfrom
yurishkuro merged 1 commit intoopentracing:masterfrom
Conversation
Currently, the no-argument constructor for the MockTracer uses a `ThreadLocalScopeManager` and a `Propagator.TEXT_MAP` as default values. But when providing a Propagator, the constructor injects a `NoopScopeManager` instead of the `ThreadLocalScopeManager`. This commit brings the Propagator constructor closer into line with the default values for this mock. Signed-off-by: Nate Hart <nhart@tableau.com>
yurishkuro
approved these changes
Mar 28, 2018
Member
|
LGTM |
Contributor
Author
|
@yurishkuro Sorry, I don't have write access to merge. |
This was referenced Mar 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the no-argument constructor for the MockTracer uses a
ThreadLocalScopeManagerand a
Propagator.TEXT_MAPas default values. But when providing a Propagator,the constructor injects a
NoopScopeManagerinstead of theThreadLocalScopeManager.This commit brings the Propagator constructor closer into line with the default
values for this mock.
cc: @yurishkuro
Signed-off-by: Nate Hart nhart@tableau.com