This repository was archived by the owner on May 23, 2023. It is now read-only.
[impl] Improve the performance of the AbstractSpanBuilder and Abstrac…#93
Closed
manolama wants to merge 1 commit intoopentracing:masterfrom
Closed
[impl] Improve the performance of the AbstractSpanBuilder and Abstrac…#93manolama wants to merge 1 commit intoopentracing:masterfrom
manolama wants to merge 1 commit intoopentracing:masterfrom
Conversation
…tSpan by lazily initializing maps and lists to avoid eating heap space when it won't be needed. Also add tons of unit tests for the AbstractSpanBuilder and AbstractSpan. Some validation should occur here if these are meant to be overridden by implementations.
Member
|
Hi, I review your code, and see your point about And here is a scenario, if a span object is hold by two thread, and |
Contributor
|
This is going to be obviated by #115, btw. I'm going to close since this is a dormant PR. If that's a problem please let me know and we'll figure something out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tSpan
by lazily initializing maps and lists to avoid eating heap space when it
won't be needed.
Also add tons of unit tests for the AbstractSpanBuilder and AbstractSpan.
Some validation should occur here if these are meant to be overridden by
implementations.