Switch to Caddy for managing certificates and fix env variables passing#11
Draft
RomanPszonka wants to merge 6 commits intoopenutm:mainfrom
Draft
Switch to Caddy for managing certificates and fix env variables passing#11RomanPszonka wants to merge 6 commits intoopenutm:mainfrom
RomanPszonka wants to merge 6 commits intoopenutm:mainfrom
Conversation
Collaborator
Author
|
@hrishiballal would need to be tested online first before merging |
There was a problem hiding this comment.
Pull request overview
This PR migrates certificate management from cert-manager with nginx-ingress-controller to Caddy ingress controller, which provides automatic HTTPS certificate management. The PR also includes unrelated database configuration improvements.
- Removes cert-manager Issuer and Certificate resources
- Replaces nginx ingress with Caddy ingress controller
- Standardizes database connection strings to use environment variables
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/issuer-template.yaml | Removed - cert-manager issuer configuration no longer needed with Caddy |
| templates/certificate-wcard-template.yaml | Removed - Caddy handles wildcard certificates automatically |
| templates/certificate-root-template.yaml | Removed - Caddy handles root domain certificates automatically |
| templates/ingress-template.yaml | Migrated from nginx to Caddy ingress class, removed cert-manager annotations and TLS configuration |
| generate-from-templates.sh | Updated to only generate ingress configuration, removed cert-manager template processing |
| README.md | Updated installation instructions to use Caddy ingress controller instead of nginx + cert-manager |
| kustomize/passport/passport.yaml | Added POSTGRES_PORT environment variable and updated DATABASE_URL to use it; removed trailing whitespace |
| kustomize/passport/db-passport.yaml | Added POSTGRES_PORT environment variable |
| kustomize/blender/blender.yaml | Added POSTGRES_PORT environment variable and updated DATABASE_URL to use it; removed trailing whitespace |
| kustomize/blender/worker.yaml | Added POSTGRES_PORT environment variable and updated DATABASE_URL to use it; removed trailing whitespace |
| kustomize/blender/beat.yaml | Added POSTGRES_PORT environment variable and updated DATABASE_URL to use it; removed trailing whitespace |
| kustomize/blender/db-blender.yaml | Added POSTGRES_PORT environment variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.