The @load shouldn't json.load every argument#2294
Merged
JeffreyDevloo merged 2 commits into2.9.xfrom May 3, 2019
Merged
Conversation
…lizes it in the start
JeffreyDevloo
changed the title
JeffreyDevloo
changed the title
sjovdnbos
requested changes
May 3, 2019
webapps/api/backend/decorators.py
Outdated
| for mandatory_vars, optional_vars, new_kwargs in [(function_metadata['load']['mandatory'][:], function_metadata['load']['optional'][:], kwargs), | ||
| (validation_mandatory_vars[:], validation_optional_vars[:], validator_kwargs)]: | ||
| # Special reserved keywords | ||
| if 'version' in mandatory_vars: |
Contributor
There was a problem hiding this comment.
as this exact functionality is done 4 times, perhaps offload to a tiny function
sjovdnbos
approved these changes
May 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arguments passed to django are already deserialized