Skip to content

Add concurrency to snapshot delete. Concurrency offloaded to celery#2298

Merged
JeffreyDevloo merged 3 commits into2.9.xfrom
2.9.x_concurrent_snapshots
May 17, 2019
Merged

Add concurrency to snapshot delete. Concurrency offloaded to celery#2298
JeffreyDevloo merged 3 commits into2.9.xfrom
2.9.x_concurrent_snapshots

Conversation

@JeffreyDevloo
Copy link
Contributor

Unittests:

############
# OVERVIEW #
############

  - TestModule: /opt/OpenvStorage/ovs/dal/tests/test_alba  (2 tests)
    - DURATION: < 1 second
    - SUCCESS: 2

  - TestModule: /opt/OpenvStorage/ovs/dal/tests/test_basic  (69 tests)
    - DURATION: 1 seconds
    - SUCCESS: 69

  - TestModule: /opt/OpenvStorage/ovs/dal/tests/test_hybrids  (1 test)
    - DURATION: < 1 second
    - SUCCESS: 1

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/alba_tests/test_lib_alba  (1 test)
    - DURATION: 6 seconds
    - SUCCESS: 1

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/alba_tests/test_nsmcheckup  (1 test)
    - DURATION: 9 seconds
    - SUCCESS: 1

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/generic_tests/test_generic  (2 tests)
    - DURATION: 4 seconds
    - SUCCESS: 2

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/generic_tests/test_scrubbing  (12 tests)
    - DURATION: 31 seconds
    - SUCCESS: 12

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/generic_tests/test_snapshot  (14 tests)
    - DURATION: 11 seconds
    - SUCCESS: 14

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/helpers_tests/test_helpers  (12 tests)
    - DURATION: 2 seconds
    - SUCCESS: 12

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/mdsservice_tests/test_mdscatchup  (7 tests)
    - DURATION: 11 seconds
    - SUCCESS: 7

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/mdsservice_tests/test_mdsservice  (9 tests)
    - DURATION: 51 seconds
    - SUCCESS: 9

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/storagedriver_tests/test_controller  (1 test)
    - DURATION: < 1 second
    - SUCCESS: 1

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/storagedriver_tests/test_node_configs  (2 tests)
    - DURATION: 1 seconds
    - SUCCESS: 2

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/vdisk_tests/test_dtl_checkup  (10 tests)
    - DURATION: 17 seconds
    - SUCCESS: 10

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/vdisk_tests/test_events  (3 tests)
    - DURATION: 2 seconds
    - SUCCESS: 3

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/vdisk_tests/test_get_set_config_params  (5 tests)
    - DURATION: 2 seconds
    - SUCCESS: 5

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/vdisk_tests/test_snapshot  (4 tests)
    - DURATION: 2 seconds
    - SUCCESS: 4

  - TestModule: /opt/OpenvStorage/ovs/lib/tests/vdisk_tests/test_vdisk  (10 tests)
    - DURATION: 7 seconds
    - SUCCESS: 10

  - TestModule: /opt/OpenvStorage/webapps/api/tests/test_api_configuration  (2 tests)
    - DURATION: < 1 second
    - SUCCESS: 2

  - TestModule: /opt/OpenvStorage/webapps/api/tests/test_authentication  (8 tests)
    - DURATION: < 1 second
    - SUCCESS: 8

  - TestModule: /opt/OpenvStorage/webapps/api/tests/test_decorators  (6 tests)
    - DURATION: < 1 second
    - SUCCESS: 6


###########
# SUMMARY #
###########

  - Total amount of tests: 181
  - Total duration: 2 minutes and 40 seconds
    - SUCCESS: 181 / 181 (100.00 %)

root@DEV-3N-199-181:~# date
Fri May 10 08:40:01 CEST 2019

@staticmethod
@ovs_task(name='ovs.generic.delete_snapshots', schedule=Schedule(minute='1', hour='2'), ensure_single_info={'mode': 'DEFAULT'})
def delete_snapshots(timestamp=None):
# type: (float) -> GroupResult
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional[float]

@staticmethod
@ovs_task(name='ovs.generic.delete_snapshots_storagedriver', ensure_single_info={'mode': 'DEDUPED'})
def delete_snapshots_storagedriver(storagedriver_guid, timestamp=None, group_id=None):
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typing

@JeffreyDevloo JeffreyDevloo merged commit d689027 into 2.9.x May 17, 2019
@JeffreyDevloo JeffreyDevloo deleted the 2.9.x_concurrent_snapshots branch May 17, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants