Merged
Conversation
sjovdnbos
requested changes
Jul 1, 2019
ovs/update/volumedriver/updater.py
Outdated
| # List with tuples. [(package_name, binary_name, binary_location, [service_prefix_0]] | ||
| BINARIES = [(PACKAGES_EE, VOLUMEDRIVER_CMD_NAME, VOLUMEDRIVER_BIN_PATH, [STORAGEDRIVER_SERVICE_BASE])] # type: List[Tuple[List[str], str, str, List[str]]] | ||
| LOCAL_SR = System.get_my_storagerouter() | ||
| # @todo revert |
| :return: None | ||
| :raises: FailureDuringMigrateException if any volumes failed to move | ||
| """ | ||
| evacuate_srs = [storagerouter.guid] |
Contributor
There was a problem hiding this comment.
no need to wrap this in a list, just make it a string and do string comparison later
Improve logging Add custom exceptions Add documentation for volumedriver update
…oller Add alba to the volumedriver doc Update the ovs binary
JeffreyDevloo
force-pushed
the
2.9.x_volumedriver_update
branch
from
d4e2f51 to
108633f
Compare
sjovdnbos
approved these changes
Jul 3, 2019
Revert the edge sync time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.