(fix) Properly use VM key when signing [SD-]JWT#3892
(fix) Properly use VM key when signing [SD-]JWT#3892jamshale merged 7 commits intoopenwallet-foundation:mainfrom
Conversation
|
@PatStLouis @jamshale -- please take a look when you can. @gmulhearn -- @jamshale is on vacation today, so won't see this until next week. |
PatStLouis
left a comment
PatStLouis
left a comment
There was a problem hiding this comment.
Thanks for looking into this, its been on my radar for some time.
jamshale
left a comment
jamshale
left a comment
There was a problem hiding this comment.
This looks good to me. Removes unnecessary complexity. I'll give @PatStLouis a chance to review as he did the MultikeyManager implementation.
|
I'm going to wait to merge this. We're really trying to get the Kanon profile stuff in and I don't want to cause any potential merge conflicts withit. |
|
@jamshale sounds good! let me know when it's ready and i'll rebase this branch |
…#3892 Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
|
@gmulhearn Can you please update this with main now and we will get it merged? Thx. |
|
@gmulhearn Sorry. I merged another PR and github isn't letting me update the branch. Could you do it one more time please? |
|
5 participants
Closes #3891
Utilizes the existing MultikeyManager logic to reduce code (like is done in the w3c ldp module)