Fix tab order for the three point quadratic and four point cubic tools.#674
Merged
pstaabp merged 1 commit intoopenwebwork:PG-2.17from May 13, 2022
Merged
Conversation
There was an indexing error in the logic of the tab focus handler of the selection tool that results in the last defining point of an object that has three or more defining points not working correctly. To see the issue, graph any object and then graph a quadratic or cubic after that. Immediately after completing the graph of the quadratic or cubic hit shift-tab. With the code in the release candidate branch the focus will jump back to the last point on first object that was graphed. With this pull request the focus will go to the next to last point on the quadratic or cubic as it should.
drdrew42
approved these changes
Apr 29, 2022
pstaabp
approved these changes
May 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an indexing error in the logic of the tab focus handler of the selection tool that results in the last defining point of an object that has three or more defining points not working correctly.
To see the issue, graph any object and then graph a quadratic or cubic after that. Immediately after completing the graph of the quadratic or cubic hit shift-tab. With the code in the release candidate branch the focus will jump back to the last point on first object that was graphed. With this pull request the focus will go to the next to last point on the quadratic or cubic as it should.
You can use the attached problem to test this.
Demo.pg.txt