Fix ww3 mq-editor preview button code causing console log error in ww2 gateway quizzes.#681
Merged
pstaabp merged 1 commit intoopenwebwork:PG-2.17from Jul 6, 2022
Merged
Conversation
Member
|
Is this supposed to occur if the preview button is clicked in a gateway quiz? I'm not seeing an error. |
Member
Author
|
No. It does not happen when you click on the preview button. It occurs if the focus is in a MathQuill answer box, and then you hit enter. |
…2 gateway quizzes.
drgrice1
force-pushed
the
ww3-preview-not-in-ww2
branch
from
90b1931 to
d5d55d1
Compare
Member
Author
|
After testing this with webwork3 itself I realized that this wasn't working there either. The Element.closest method does not return a list. It just returns the closest element satisfying the selector or null if that isn't found. Previously I believe I was using a querySelectorAll which does return a list, and when I changed it, I forgot to drop the index. |
pstaabp
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a gateway quiz since the form by the name
problemMainFormdoes not exist, the webwork 3 code that looks form the preview button of a specific problem to click when enter is pressed in a MathQuill answer box returns an empty list. This causes a console error message.