MathQuill fix for RTL languages#686
Merged
pstaabp merged 1 commit intoopenwebwork:PG-2.17from May 31, 2022
Merged
Conversation
the input boxes as LTR and the menu should internally be in LTR so the symbols will appear properly.
drgrice1
approved these changes
May 30, 2022
Member
drgrice1
left a comment
There was a problem hiding this comment.
Looks good.
So you have time for a little testing now? That is good. Hopefully you are looking around the user interface for other things like this. The right-to-left styles have changed quite a bit, and I have only done minimal testing with this, partially due to not exactly knowing what to look for.
pstaabp
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MathQuill when used in an RTL language should still create the input boxes as LTR and the menu should internally be in LTR so the symbols will appear properly.
To test, open a problem (the
blankProblem.pgis good enough).Change the course language to
he-il(you can add$language = 'he-il';to thesimple.conffile of the course, and then comment/uncomment that line when testing).Before the patch:
4^5orsqrtwill get a messed up display inside the formatted input box.5!will get the factorial displayed on the left side of the5.sin(5x)puts the argument on the left of thesin.The patch tells
rtlcssnot to mirror thedirectionsettings which were intended to prevent such problems.After installing the patch you need to run
npm installin/opt/webwork/pg/htdocsbefore checking that the fix works.