Make knowls wait until the page css has loaded before initializing.#696
Merged
pstaabp merged 1 commit intoopenwebwork:PG-2.17from Jul 13, 2022
Merged
Make knowls wait until the page css has loaded before initializing.#696pstaabp merged 1 commit intoopenwebwork:PG-2.17from
pstaabp merged 1 commit intoopenwebwork:PG-2.17from
Conversation
This fixes issue openwebwork/webwork2#1739. In the PG problem editor, the page in the iframe is not displayed until after the page loads. As such the javascript getComputedStyle method fails. The same things happens with the graphtool. The same solution is now implemented for knowls.
Member
Author
|
When testing this make sure to remember to run |
somiaj
approved these changes
Jul 13, 2022
Contributor
somiaj
left a comment
somiaj
left a comment
There was a problem hiding this comment.
I can confirm this makes solution knowls work for me again in the problem editor.
Member
|
This patch works for me also |
somiaj
approved these changes
Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue webwork2#1739.
In the PG problem editor, the page in the iframe is not displayed until
after the page loads. As such the javascript getComputedStyle method
fails. The same things happens with the graphtool. The same solution
is now implemented for knowls.