Fix an errant regex check that doubly base64 encoded Geogebra applet states (hotfix)#751
Merged
pstaabp merged 1 commit intoopenwebwork:mainfrom Dec 3, 2022
Conversation
…states. I disovered this thanks to an observation of @drdrew's while attempting to diagnose an issue with a Geogebra problem written by another author. It turns out that one part of the problem was the applet state being doubly base64 encoded.
drdrew42
approved these changes
Nov 23, 2022
Member
|
Thanks! 🙏 |
Member
|
I'll take @drdrew42 approval as enough, unless you want more testing. If more testing is requested, what pg problem does this fix the problem for? |
Member
Author
|
Here is the problem that was causing the issue: Without this pull request the state is double encoded when answers are submitted. |
Member
|
With that problem, upon submission the values in the geogebra table stay. Values were being cleared out (on the develop branch), so I think this may have been the issue and may be fixed. However, any answers in the geogebra table are not being submitted as WeBWorK answers. Should they be? |
Member
Author
|
They should not be submitted as webwork answers. That is not implemented in the problem. |
pstaabp
approved these changes
Dec 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I disovered this thanks to an observation of @drdrew's while attempting to diagnose an issue with a Geogebra problem written by another author. It turns out that one part of the problem was the applet state being doubly base64 encoded.