Fix and deprecate unionInclude.pl#769
Merged
pstaabp merged 2 commits intoopenwebwork:developfrom Feb 2, 2023
Merged
Conversation
drgrice1
force-pushed
the
fix-and-deprecate-unionInclude
branch
from
79aaf66 to
58d6c46
Compare
Make the unionInclude.pl macro work again. `fileName` is no longer in the environment. Instead of having `fileName` and `probFileName` in the environment that were both always the same thing, there is now only `probFileName`. However, this macro should not be used anymore, so it is also moved to deprecated.
drgrice1
force-pushed
the
fix-and-deprecate-unionInclude
branch
from
58d6c46 to
54939e8
Compare
pstaabp
approved these changes
Feb 2, 2023
Member
pstaabp
left a comment
pstaabp
left a comment
There was a problem hiding this comment.
This does fix a warning from the macro and YES this should be deprecated. In order to actually work, problems need to be setup in the right way relative to others in the set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the unionInclude.pl macro work again.
fileNameis no longer in the environment. Instead of havingfileNameandprobFileNamein the environment that were both always the same thing, there is now onlyprobFileName.However, this macro should not be used anymore, so it is also moved to deprecated.
There is also a minor fix for a warning in niceTables.pl that I keep seeing. This was included in #709 and accidentally reverted in #724.