Skip to content

Conversation

@drgrice1
Copy link
Member

@drgrice1 drgrice1 commented Mar 5, 2023

With breaking changes coming to MathQuill, PG-2.17 needs to be locked into using the current version of MathQuill. This locks PG-2.17 to the WeBWorK-2.17 tag in our MathQuill repository.

Obviously this needs to be a hotfix. It can't be anything else.

With breaking changes coming to MathQuill, PG-2.17 needs to be locked
into using the current version of MathQuill.  This locks PG-2.17 to
the WeBWorK-2.17 tag in our MathQuill repository.
@drgrice1
Copy link
Member Author

drgrice1 commented Mar 5, 2023

I guess this really isn't needed if we make sure that everyone starts using npm ci instead of npm install. The package-lock.json file is used with npm ci and the sha hash in the package-lock.json file for PG-2.17 is exactly for the commit tagged by the tag added in this commit.

@pstaabp pstaabp merged commit 3f57377 into openwebwork:main Mar 9, 2023
@drgrice1 drgrice1 deleted the hotfix-lock-mathquill-version branch March 9, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants