Update the renderer for the restructuring of PG in openwebwork/pg#709#7
Merged
drdrew42 merged 1 commit intoopenwebwork:developfrom May 22, 2023
Merged
Conversation
Member
Author
|
Note that this should not be merged until after the referenced pg pull request, and the git submodule will need to be updated before this is merged. Also, we need to discuss the state of this repository in relation to the PG 2.17 release. Currently the develop branch is up to date to work with PG 2.17. The main branch is set to work with PG 2.16. This pull request (if merged) will take the develop branch past the PG 2.17 release. So should develop be merged into main, and a "release" made to match PG 2.17 and tag the current commit in main for PG 2.16? |
drgrice1
force-pushed
the
pg-environment-work
branch
16 times, most recently
from
4ec2614 to
a6bd912
Compare
drgrice1
force-pushed
the
pg-environment-work
branch
3 times, most recently
from
c5aec52 to
496e77f
Compare
drgrice1
force-pushed
the
pg-environment-work
branch
9 times, most recently
from
6495bc5 to
8801a38
Compare
drgrice1
force-pushed
the
pg-environment-work
branch
2 times, most recently
from
8c72c35 to
351f7e7
Compare
Closed
drgrice1
force-pushed
the
pg-environment-work
branch
2 times, most recently
from
76395e7 to
f31362a
Compare
drgrice1
force-pushed
the
pg-environment-work
branch
3 times, most recently
from
72e9bbf to
ab80799
Compare
drgrice1
force-pushed
the
pg-environment-work
branch
from
ab80799 to
dbedb41
Compare
drgrice1
force-pushed
the
pg-environment-work
branch
2 times, most recently
from
8e62047 to
bb7b04f
Compare
Member
Author
|
This is now updated to work with the current develop branch of PG. Note that the updated |
The WeBWorK::PG module is now part of PG, and PG has its own environment
so the webwork2 WeBWorK::PG module (and its derivatives) have been
removed.
The WeBWorK::Constants, WeBWorK::Debug, and WeBWork::CourseEnvironment
modules and the webwork2 conf files are no longer needed and so are
removed. The renderer uses the WeBWorK::PG::Environment module which is
part of PG. Note that this adds one minor installation step for the
renderer. The file conf/pg_config.yml must be copied to lib/PG/conf.
Usually that file will work as is, but in some cases administrators may
want to make changes to it. For example, the externalPrograms are the
standard linux executables and in the standard locations. On some
systems those may need to be changed.
Most of the WeBWorK::Utils module has been removed. All that is left is
the two methods that the renderer uses.
In addition the renderer lib directory has been flattened.
lib/WeBWorK/lib/WeBWorK is now just lib/WeBWorK. With this (among other
things) the WEBWORK_ROOT environment variable is not needed. Note that
$WeBWorK::Constants::PG_DIRECTORY is not available. $ENV{PG_ROOT} is
used instead in the renderer code.
Note that the unnecessary encoding and decoding of perl warnings has
been removed.
Also note that the references to drdrew42 have been changed to
openwebwork.
drgrice1
force-pushed
the
pg-environment-work
branch
from
bb7b04f to
080c0e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WeBWorK::PG module is now part of PG, and PG has its own environment so the webwork2 WeBWorK::PG module (and its derivatives) have been removed.
The WeBWorK::Constants, WeBWorK::Debug, and WeBWork::CourseEnvironment modulesa and the webwork2 conf files are no longer needed and so are removed. The renderer uses the WeBWorK::PG::Environment module which is part of PG. Note that this adds one minor installation step for the renderer. The file
renderer/conf/pg_config.ymlmust be copied torenderer/lib/PG/conf. Usually that file will work as is, but in some cases administrators may want to make changes to it. For example, the externalPrograms are the standard linux executables and in the standard locations. On some systems those may need to be changed.Most of the WeBWorK::Utils module has been removed. All that is left is the two methods that the renderer uses.
In addition the renderer lib directory has been flattened. lib/WeBWorK/lib/WeBWorK is now just lib/WeBWorK. With this (among other things) the WEBWORK_ROOT environment variable is not needed. Note that $WeBWorK::Constants::PG_DIRECTORY is not available. $ENV{PG_ROOT} is used instead in the renderer code.
Note that the unnecessary encoding and decoding of perl warnings has been removed.
Also note that the references to drdrew42 have been changed to openwebwork.