ProblemSetList inconsistent use of "visible sets" (2 different meaning)

[taniwallach]

In the file lib/WeBWorK/ContentGenerator/Instructor/ProblemSetList.pm in the pull-down menu options the option "visible sets" seems to have 2 different meanings:

• In the "filter" menu - the meaning is that the set has been "published" (made visible) to the students.
• In the "edit" and "export" menus - the meaning is that the set is currently displayed in the table.

Filtering to a small group of sets, and using these options seems to be the best way to confirm what they actually mean/do.

This inconsistent usage is both confusing for users and makes proper translation challenging.

Maybe the options could better be called

• Filter: "published sets" or "sets visible to students"
• Edit/Export: "listed sets" or "sets displayed in the table" or something similar which makes it clear that it refers to what appears on screen and not to the "published / not-published" status of sets.

I suspect that we do not want to rename the variable visibleSetIDs which seems to control what is displayed and appears in many places.

@drgrice1 @mgage @pstaabp - Comments / suggestions?

[drgrice1]

I agree that this should be changed. The different meanings of Visible is quite misleading.

I think that the Filter select should be changed to say "sets visible to students" (and "sets hidden from students" for hidden sets), and the Edit/Export selects should be changes to say "listed sets" (I am fine with "sets displayed in table" also, but "listed sets" is shorter and I think it gets the point accross). There is no need to change variable names (and the corresponding parameter), just front end text, although it would be better to do so as it can also be confusing to developers trying to understand the code. That can wait though.

[taniwallach]

Being fixed by #1646 which is essentially ready to merge.