Conversation
and all files in htdocs/applets, htdocs/html_templates, and htdocs/codemirror2. The file htdocs/js/vendor/jquery/modules/jstorage.js was actually used by htdocs/js/apps/LocalStorage/localstorage.js, but that file has been updated to use native javascript, and so no longer uses it. The files htdocs/css/jquery-ui-timepicker-addon.css and htdocs/js/apps/DatePicker/jquery-ui-timepicker-addon.js have been removed, and that is now installed via npm. Note that several of the other files are used by pg/macros/LiveGraphics3d.pl, but that macro heavily depends on flash and java, and as such will be deleted. The javascript for that macro is also deleted here. Also remove the unused, unmaintained, and unlinked to files lib/WeBWorK/ContentGenerator/Instructor/Compare.pm, lib/WeBWorK/ContentGenerator/Instructor/GetTargetSetProblems.pm, lib/WeBWorK/ContentGenerator/Instructor/GetLibrarySetProblems.pm, lib/WeBWorK/ContentGenerator/Instructor/Preflight.pm and their corresponding paths in lib/WeBWorK/URLPath.pm.
Member
|
An initial pull of this and going through all of the pages seems to not generate any errors--which I think is the big point of this. |
drdrew42
approved these changes
Jan 25, 2022
Member
drdrew42
left a comment
drdrew42
left a comment
There was a problem hiding this comment.
🥳
Should this wait until after we merge the flatpicker? or does it matter?
Member
Author
|
That shouldn't matter. I can fix the merge conflict. |
Member
Author
|
Either way, one of the pull requests will have a merge conflict anyway. |
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Jan 27, 2022
show a warning if these methods are called. So if a problem in the OPL is used that uses one of these deprecated applet types, intructors will know not to use the problem. Also stub out the findAppletCodebase method in PGalias.pm. None of those "codebases" will work anymore, and soon they will be deleted (via openwebwork/webwork2#1553) which will cause this method to fail with errors. Interestingly some of the Geogebra problems in the opl that call this method still work, even with this stub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused files in htdocs/js/vendor, htdocs/css, htdocs/images, and all files in htdocs/applets, htdocs/html_templates, and htdocs/codemirror2.
The file htdocs/js/vendor/jquery/modules/jstorage.js was actually used by htdocs/js/apps/LocalStorage/localstorage.js, but that file has been updated to use native javascript, and so no longer uses it.
The files htdocs/css/jquery-ui-timepicker-addon.css and htdocs/js/apps/DatePicker/jquery-ui-timepicker-addon.js have been removed, and that is now installed via npm. This will conflict with another pull request of mine, but it is easy enough to resolve.
Note that several of the other files are used by pg/macros/LiveGraphics3d.pl, but that macro heavily depends on flash and java, and as such will be deleted. The javascript for that macro is also deleted here.
Also remove the unused, unmaintained, and unlinked to files
lib/WeBWorK/ContentGenerator/Instructor/Compare.pm,
lib/WeBWorK/ContentGenerator/Instructor/GetTargetSetProblems.pm,
lib/WeBWorK/ContentGenerator/Instructor/GetLibrarySetProblems.pm,
lib/WeBWorK/ContentGenerator/Instructor/Preflight.pm and
their corresponding paths in lib/WeBWorK/URLPath.pm.
If anyone sees a reason to keep a file that was deleted here, make sure to speak up.