Show set header in proctored login.#1810
Merged
drdrew42 merged 1 commit intoopenwebwork:developfrom Oct 19, 2022
Merged
Conversation
drgrice1
approved these changes
Oct 5, 2022
Member
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
The code looks good (although could perhaps be perltidied!).
I think this makes more sense than showing the site info and login info on this page. However, since this was implemented this way, it may be that there are those that think otherwise.
Member
|
Actually, thinking about it more, I forgot that set headers were not used for gateway quizzes before. So that is probably why the site info was shown. Now that the set header is used for gateway quizzes this makes more sense. |
somiaj
force-pushed
the
proctor-login-use-set-info
branch
from
e1bbc84 to
eff59d7
Compare
Contributor
Author
|
Removed an unused variable in my code, and ran perltidy on the whole file. |
pstaabp
approved these changes
Oct 5, 2022
somiaj
force-pushed
the
proctor-login-use-set-info
branch
from
eff59d7 to
7d6afd5
Compare
Contributor
Author
|
Code cleanup. Replaced some double quoted strings with single quotes. |
Member
Use the set header for the page info-box when at a login prompt for a proctored gateway quiz instead of showing the site info or login info. Run perltidy on LoginProctor.pm
somiaj
force-pushed
the
proctor-login-use-set-info
branch
from
7d6afd5 to
b3f4f01
Compare
drdrew42
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the set header for the page info-box when at a login prompt for a proctored gateway quiz instead of showing the site info or login info.