Fix an issue in gateway quizzes that causes correct answers to be displayed on all submissions.#1812
Merged
pstaabp merged 1 commit intoopenwebwork:developfrom Oct 19, 2022
Conversation
…played on all submissions.
The removal of the $pg{options}{showCorrectAnswers} from defaults.config
made it so that the $want->{showProblemGrader} value in GatewayQuiz.pm
could possibly be undefined. As a result the AttemptsTable.pm code
defaulted to showing correct answers. Both of those are changed. A
fallback was added so that the $want->{showProblemGrader} is now defined
and 0 in this case. Although that isn't really needed. Why did the
AttemptsTable.pm default to displaying correct answers if the
showCorrectAnswers option was undefined? That doesn't make sense. So
that default is changed.
pstaabp
approved these changes
Oct 19, 2022
drdrew42
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removal of the $pg{options}{showCorrectAnswers} from defaults.config in #1792 made it so that the $want->{showProblemGrader} value in GatewayQuiz.pm could possibly be undefined. As a result the AttemptsTable.pm code defaulted to showing correct answers. Both of those are changed. A fallback was added so that the $want->{showProblemGrader} is now defined and 0 in this case. Although that isn't really needed. Why did the AttemptsTable.pm default to displaying correct answers if the showCorrectAnswers option was undefined? That doesn't make sense. So that default is changed.