Skip to content

[change] DeviceConnection.update_config will not flag as applied #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nemesifier merged 1 commit into from
Apr 17, 2024
Merged

[change] DeviceConnection.update_config will not flag as applied #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion openwisp_controller/connection/base/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,6 @@ def update_config(self):
except Exception as e:
logger.exception(e)
else:
self.device.config.set_status_applied()
self.disconnect()

def save(self, *args, **kwargs):
Expand Down
4 changes: 2 additions & 2 deletions openwisp_controller/connection/tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,7 @@ def _assert_applying_conf_test_command(mocked_exec):
args, _ = mocked_exec_command.call_args_list[1]
self.assertIn('OW_CONFIG_PID', args[0])
conf.refresh_from_db()
self.assertEqual(conf.status, 'applied')
self.assertEqual(conf.status, 'modified')

with self.subTest('openwisp_config < 0.6.0a: exit_code 0'):
conf.config = '{"interfaces": [{"name": "eth00","type": "ethernet"}]}'
Expand All @@ -942,7 +942,7 @@ def _assert_applying_conf_test_command(mocked_exec):
_assert_version_check_command(mocked_exec_command)
_assert_applying_conf_test_command(mocked_exec_command)
conf.refresh_from_db()
self.assertEqual(conf.status, 'applied')
self.assertEqual(conf.status, 'modified')

with self.subTest('openwisp_config < 0.6.0a: exit_code 1'):
conf.config = '{"radios": []}'
Expand Down