Skip to content

[chores] Fixed commitizen rules: test > tests#597

Merged
nemesifier merged 2 commits intomasterfrom
fix-commitizen-tests-prefix
Feb 26, 2026
Merged

[chores] Fixed commitizen rules: test > tests#597
nemesifier merged 2 commits intomasterfrom
fix-commitizen-tests-prefix

Conversation

@nemesifier
Copy link
Copy Markdown
Member

Fixed commitizen rules: test > tests.

@nemesifier nemesifier self-assigned this Feb 26, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 184f314 and a43d320.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
📜 Recent review details
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: nemesifier
Repo: openwisp/openwisp-utils PR: 560
File: openwisp_utils/commitizen/openwisp.py:9-25
Timestamp: 2026-02-06T20:46:32.980Z
Learning: In openwisp-utils, the commit message prefix "chores" (plural) is intentionally used instead of "chore" (singular) in the Commitizen ALLOWED_PREFIXES configuration.
Learnt from: nemesifier
Repo: openwisp/openwisp-utils PR: 593
File: openwisp_utils/releaser/commitizen.py:5-9
Timestamp: 2026-02-10T20:38:27.593Z
Learning: In openwisp-utils commitizen implementation, the `_TITLE_ISSUE_EXTRACT_RE` pattern intentionally matches any space-preceded `#<number>` in commit titles without anchoring to the end. This is acceptable because 99.9% of such patterns are actual issue references, and rare edge cases (like version numbers) will be handled manually if they occur.
🔇 Additional comments (2)
.github/workflows/ci.yml (2)

97-97: Non-fatal matrix coverage upload is a good stability choice.

This prevents transient Coveralls upload errors from failing otherwise healthy CI runs.


107-107: Good consistency on final Coveralls step.

Using fail-on-error: false here aligns behavior with the upload step and avoids unnecessary red builds from external service instability.


📝 Walkthrough

Walkthrough

Renames the commitizen allowed commit prefix "test" to "tests" in openwisp_utils/releaser/commitizen.py, updates tests in openwisp_utils/releaser/tests/test_commitizen_rules.py to use the plural prefix and adjusts expected documentation output accordingly, and adds fail-on-error: false to the "Upload Coverage" step in .github/workflows/ci.yml.

Sequence Diagram(s)

(No sequence diagrams generated — changes are small and do not introduce new multi-component control flow.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is minimal and does not follow the required template structure, missing key sections like checklist, reference to existing issue, and detailed description. Complete the description template by adding the checklist items, issue reference, and detailed explanation of why the prefix was changed and how it affects the project.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: renaming the commit prefix from 'test' to 'tests' in the commitizen rules configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-commitizen-tests-prefix

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the helper-bots Helper bots, release management automation label Feb 26, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@openwisp_utils/releaser/tests/test_commitizen_rules.py`:
- Around line 36-37: The test test_info_includes_all_prefixes contains a stale
assertion checking for the string "- test"; update that assertion to match the
renamed allowed prefix (change "- test" to "- tests" or the exact new prefix
used elsewhere, e.g., "tests") so it reflects the current prefix list; locate
and modify the assertion inside test_info_includes_all_prefixes in
openwisp_utils/releaser/tests/test_commitizen_rules.py.

ℹ️ Review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 782c8d9 and ce1177a.

📒 Files selected for processing (2)
  • openwisp_utils/releaser/commitizen.py
  • openwisp_utils/releaser/tests/test_commitizen_rules.py
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
  • GitHub Check: Python==3.11 | django~=4.2.0
  • GitHub Check: Python==3.10 | django~=4.2.0
  • GitHub Check: Python==3.12 | django~=5.2.0
  • GitHub Check: Python==3.10 | django~=5.1.0
  • GitHub Check: Python==3.11 | django~=5.0.0
  • GitHub Check: Python==3.13 | django~=5.1.0
  • GitHub Check: Python==3.11 | django~=5.2.0
  • GitHub Check: Python==3.12 | django~=5.1.0
  • GitHub Check: Python==3.10 | django~=5.0.0
  • GitHub Check: Python==3.10 | django~=5.2.0
  • GitHub Check: Python==3.12 | django~=4.2.0
  • GitHub Check: Python==3.11 | django~=5.1.0
  • GitHub Check: Python==3.12 | django~=5.0.0
  • GitHub Check: Python==3.13 | django~=5.2.0
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: nemesifier
Repo: openwisp/openwisp-utils PR: 560
File: openwisp_utils/commitizen/openwisp.py:9-25
Timestamp: 2026-02-06T20:46:32.980Z
Learning: In openwisp-utils, the commit message prefix "chores" (plural) is intentionally used instead of "chore" (singular) in the Commitizen ALLOWED_PREFIXES configuration.
Learnt from: nemesifier
Repo: openwisp/openwisp-utils PR: 593
File: openwisp_utils/releaser/commitizen.py:5-9
Timestamp: 2026-02-10T20:38:27.593Z
Learning: In openwisp-utils commitizen implementation, the `_TITLE_ISSUE_EXTRACT_RE` pattern intentionally matches any space-preceded `#<number>` in commit titles without anchoring to the end. This is acceptable because 99.9% of such patterns are actual issue references, and rare edge cases (like version numbers) will be handled manually if they occur.
📚 Learning: 2026-02-06T20:46:32.980Z
Learnt from: nemesifier
Repo: openwisp/openwisp-utils PR: 560
File: openwisp_utils/commitizen/openwisp.py:9-25
Timestamp: 2026-02-06T20:46:32.980Z
Learning: In openwisp-utils, the commit message prefix "chores" (plural) is intentionally used instead of "chore" (singular) in the Commitizen ALLOWED_PREFIXES configuration.

Applied to files:

  • openwisp_utils/releaser/tests/test_commitizen_rules.py
  • openwisp_utils/releaser/commitizen.py
📚 Learning: 2026-02-10T20:38:27.593Z
Learnt from: nemesifier
Repo: openwisp/openwisp-utils PR: 593
File: openwisp_utils/releaser/commitizen.py:5-9
Timestamp: 2026-02-10T20:38:27.593Z
Learning: In openwisp-utils commitizen implementation, the `_TITLE_ISSUE_EXTRACT_RE` pattern intentionally matches any space-preceded `#<number>` in commit titles without anchoring to the end. This is acceptable because 99.9% of such patterns are actual issue references, and rare edge cases (like version numbers) will be handled manually if they occur.

Applied to files:

  • openwisp_utils/releaser/commitizen.py
🧬 Code graph analysis (1)
openwisp_utils/releaser/tests/test_commitizen_rules.py (1)
openwisp_utils/releaser/commitizen.py (1)
  • message (83-99)
🔇 Additional comments (1)
openwisp_utils/releaser/commitizen.py (1)

21-21: Prefix rename is correct and consistent.

Switching to "tests" in ALLOWED_PREFIXES is aligned with the stated convention update and keeps the list internally consistent.

Comment thread openwisp_utils/releaser/tests/test_commitizen_rules.py
@nemesifier nemesifier force-pushed the fix-commitizen-tests-prefix branch from ce1177a to 184f314 Compare February 26, 2026 19:42
coderabbitai[bot]
coderabbitai Bot previously approved these changes Feb 26, 2026
@nemesifier nemesifier merged commit 00e1083 into master Feb 26, 2026
20 checks passed
@nemesifier nemesifier deleted the fix-commitizen-tests-prefix branch February 26, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement helper-bots Helper bots, release management automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant