Skip to content

xz: change url to sourceforge.net and use xz tarball#3275

Closed
diizzyy wants to merge 1 commit intoopenwrt:masterfrom
diizzyy:patch-10
Closed

xz: change url to sourceforge.net and use xz tarball#3275
diizzyy wants to merge 1 commit intoopenwrt:masterfrom
diizzyy:patch-10

Conversation

@diizzyy
Copy link
Contributor

@diizzyy diizzyy commented Oct 1, 2016

Maintainer: @psycho-nico

Description:

Changes URL to sourceforge.net mirrors and uses xz tarball instead.

Signed-off-by: Daniel Engberg daniel.engberg.lists@pyret.net

@xypron
Copy link
Contributor

xypron commented Oct 2, 2016

@diizzyy

Changing to source forge mirrors should be done.

The commit message does not explain why we should change to an xz tarball.

Regards

Heinrich Schuchardt

@diizzyy
Copy link
Contributor Author

diizzyy commented Oct 2, 2016

I can add it to the commit message if it's needed but to save bandwidth, diskspace and better align to base packages since many already use xz packaging and it makes little to no sense downloading the same code in different packaging. lede-project/source#361 (switching the rest to xz tarballs and packaging). The URL change will be in another pull request.

PKG_MD5SUM:=f90c9a0c8b259aee2234c4e0d7fd70af
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
PKG_SOURCE_URL:=@SF/lzmautils
PKG_MD5SUM:=e26772b69940085c0632589ab1d52e64
Copy link
Member

@yousong yousong Nov 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should at least keep the tukaani.org URL as it seems to be (one of) the official site of the package besides the fact that I encountered many times the situation where connections to sourceforge just timed out.

BTW., please consider being verbose about the change in commit message as you have presented in the comment. It may help facilitate the review process.

@xypron
Copy link
Contributor

xypron commented Nov 11, 2016

lede/tools/xz/Makefile downloads the bz2 archive. So the switch of the archive format makes sense.

tukaani.org is the upstream location of the xz packages. I see no reason to use an unoffical mirror.

Regards

Heinrich Schuchardt

@diizzyy
Copy link
Contributor Author

diizzyy commented Nov 12, 2016

http://tukaani.org/xz/old.html
"Due to bandwidth quota, some of the links below redirect to the XZ Utils files section on Sourceforge. This means that if you use a web browser (detected from the user agent), you will see the Sourceforge download page before the download starts. The redirection shouldn't affect users of GNU Wget and similar utilities. "
http://sourceforge.net/projects/lzmautils/files/

I don't see why we can't adhere that, also sf.net have several mirrors making it more reliable in that regard.

Best regards,
Daniel

@hnyman
Copy link
Contributor

hnyman commented Nov 12, 2016

Preferring SF is ok, but I don't like dropping the upstream home sites of projects.

SF could be declared first, and fossies and tukaani as the fallback options. Also SF has downtime or connection problems every now and then so it is good to have fallback options.

@diizzyy
Copy link
Contributor Author

diizzyy commented Nov 12, 2016

That's a reasonable trade off, any objections?

@xypron
Copy link
Contributor

xypron commented Nov 13, 2016

@diizzyy
Could you, please, update the patch as recommended above.

  • Keep old version number as the source doesn't change.
  • Keep tukaani source site and add SF.

Best regards

Heinrich

@diizzyy
Copy link
Contributor Author

diizzyy commented Nov 13, 2016

@xypron Fixed :-)

Changes URL to sourceforge.net mirrors and uses xz tarball instead.

Signed-off-by: Daniel Engberg <daniel.engberg.lists@pyret.net>
@yousong
Copy link
Member

yousong commented Nov 14, 2016

lede/tools/xz/Makefile downloads the bz2 archive. So the switch of the archive format makes sense.

In context of this information, I don't think the switch to xz tarball for xz package here makes sense unless tools/xz is to be dropped from the base system and present as a prereq as with bzip2. Otherwise we will have to download an extra copy of xz package.

@yousong
Copy link
Member

yousong commented Dec 17, 2016

Close this one for now because base system at the moment uses tar.bz2 tarball.

@yousong yousong closed this Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments