xz: change url to sourceforge.net and use xz tarball#3275
xz: change url to sourceforge.net and use xz tarball#3275diizzyy wants to merge 1 commit intoopenwrt:masterfrom diizzyy:patch-10
Conversation
|
Changing to source forge mirrors should be done. The commit message does not explain why we should change to an xz tarball. Regards Heinrich Schuchardt |
|
I can add it to the commit message if it's needed but to save bandwidth, diskspace and better align to base packages since many already use xz packaging and it makes little to no sense downloading the same code in different packaging. lede-project/source#361 (switching the rest to xz tarballs and packaging). The URL change will be in another pull request. |
| PKG_MD5SUM:=f90c9a0c8b259aee2234c4e0d7fd70af | ||
| PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz | ||
| PKG_SOURCE_URL:=@SF/lzmautils | ||
| PKG_MD5SUM:=e26772b69940085c0632589ab1d52e64 |
There was a problem hiding this comment.
I think we should at least keep the tukaani.org URL as it seems to be (one of) the official site of the package besides the fact that I encountered many times the situation where connections to sourceforge just timed out.
BTW., please consider being verbose about the change in commit message as you have presented in the comment. It may help facilitate the review process.
|
lede/tools/xz/Makefile downloads the bz2 archive. So the switch of the archive format makes sense. tukaani.org is the upstream location of the xz packages. I see no reason to use an unoffical mirror. Regards Heinrich Schuchardt |
|
http://tukaani.org/xz/old.html I don't see why we can't adhere that, also sf.net have several mirrors making it more reliable in that regard. Best regards, |
|
Preferring SF is ok, but I don't like dropping the upstream home sites of projects. SF could be declared first, and fossies and tukaani as the fallback options. Also SF has downtime or connection problems every now and then so it is good to have fallback options. |
|
That's a reasonable trade off, any objections? |
|
@diizzyy
Best regards Heinrich |
|
@xypron Fixed :-) |
Changes URL to sourceforge.net mirrors and uses xz tarball instead. Signed-off-by: Daniel Engberg <daniel.engberg.lists@pyret.net>
In context of this information, I don't think the switch to xz tarball for xz package here makes sense unless |
|
Close this one for now because base system at the moment uses tar.bz2 tarball. |
Maintainer: @psycho-nico
Description:
Changes URL to sourceforge.net mirrors and uses xz tarball instead.
Signed-off-by: Daniel Engberg daniel.engberg.lists@pyret.net