Skip to content

PBID-450: rename hasUserData field to more descriptive userIdProviders #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kenan Gillet (kenan-gillet) merged 1 commit into from
Jun 16, 2020
Merged

PBID-450: rename hasUserData field to more descriptive userIdProviders #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/openxAnalyticsAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,7 +1145,7 @@ function buildAuctionPayload(auction) {
browser: detectBrowser(),
testCode: analyticsConfig.testCode,
// return an array of module name that have user data
hasUserData: buildHasUserDataPayload(userIds),
userIdProviders: buildUserIdProviders(userIds),
adUnits: buildAdUnitsPayload(adUnitCodeToAdUnitMap),
};

Expand Down Expand Up @@ -1213,7 +1213,7 @@ function buildAuctionPayload(auction) {
});
}

function buildHasUserDataPayload(userIds) {
function buildUserIdProviders(userIds) {
return utils._map(userIds, (userId) => {
return utils._map(userId, (id, module) => {
return hasUserData(module, id) ? module : false
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/openxAnalyticsAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,7 @@ describe('openx analytics adapter', function() {
});

it('should track the user ids', function () {
expect(auction.hasUserData).to.deep.equal(['bla_id', 'digitrustid', 'lipbid', 'tdid']);
expect(auction.userIdProviders).to.deep.equal(['bla_id', 'digitrustid', 'lipbid', 'tdid']);
});

it('should not have responded', function () {
Expand Down