Convert stablehlo.dynamic_slice into tosa.slice when indices are const #2882
+64
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvish
changed the title
vvish
force-pushed
the
vvish/feat/tosa_shlo_dyn_slice
branch
from
73f8c68 to
1f31053
Compare
vvish
force-pushed
the
vvish/feat/tosa_shlo_dyn_slice
branch
from
1f31053 to
200e9bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
stablehlo->tosatransformation is applied without stablehlo dynamism canonicalization (as a part of e.g.stablehlo-canonicalize-dynamismorstablehlo-aggressive-simplification)stablehlo.dynamic_slicecan be converted intotosa.sliceif the indices are const.