Fix removal of constraints using dimensions in RemoveUnusedSymbols. #14901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_652413273
branch
from
2f59c7c to
f52c867
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_652413273
branch
from
f52c867 to
f174b2e
Compare
Removing a constraint on a dimension is invalid, even if the dimension is unused in the affine map. The constraint still restricts the domain of the map. In some cases we could use the constraint to tighten the bounds of the unused dimension instead, e.g. if both d0 and s0 are unused in: ``` d0 in [0, 100] s0 in [2, 3] d0 + s0 in [2, 3] ``` We could change the bound of d0 to [0, 1]. But this is not always possible and requires some extra work. PiperOrigin-RevId: 652431649
copybara-service
bot
force-pushed
the
test_652413273
branch
from
f174b2e to
5ab60da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix removal of constraints using dimensions in RemoveUnusedSymbols.
Removing a constraint on a dimension is invalid, even if the
dimension is unused in the affine map. The constraint still
restricts the domain of the map.
In some cases we could use the constraint to tighten the bounds
of the unused dimension instead, e.g. if both d0 and s0 are unused
in:
We could change the bound of d0 to [0, 1]. But this is not always possible and
requires some extra work.