Add size for CudaCubinInMemory #9045
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sub PR of #9042 |
Contributor
|
Hi @penpornk, any update on this PR? Thanks |
dimitar-asenov
approved these changes
Mar 5, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
Imported from GitHub PR #9045 This is a sub PR to add SPIR target in openxla. `CudaCubinInMemory` is an object represents compiled binary for different backends. `char* bytes` is enough for cuda backend, but spir requires additional `int size` to load the binary. Copybara import of the project: -- 59270e8 by Sheng, Yang <yang.sheng@intel.com>: Add size for CudaCubinInMemory Merging this change closes #9045 FUTURE_COPYBARA_INTEGRATE_REVIEW=#9045 from Intel-tensorflow:yang/cubin 59270e8 PiperOrigin-RevId: 613135362
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Imported from GitHub PR #9045 This is a sub PR to add SPIR target in openxla. `CudaCubinInMemory` is an object represents compiled binary for different backends. `char* bytes` is enough for cuda backend, but spir requires additional `int size` to load the binary. Copybara import of the project: -- 59270e8 by Sheng, Yang <yang.sheng@intel.com>: Add size for CudaCubinInMemory Merging this change closes #9045 FUTURE_COPYBARA_INTEGRATE_REVIEW=#9045 from Intel-tensorflow:yang/cubin 59270e8 PiperOrigin-RevId: 613135362
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 7, 2024
Imported from GitHub PR openxla/xla#9045 This is a sub PR to add SPIR target in openxla. `CudaCubinInMemory` is an object represents compiled binary for different backends. `char* bytes` is enough for cuda backend, but spir requires additional `int size` to load the binary. Copybara import of the project: -- 59270e8c02438425e508067aeb92da828630bdcc by Sheng, Yang <yang.sheng@intel.com>: Add size for CudaCubinInMemory Merging this change closes #9045 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#9045 from Intel-tensorflow:yang/cubin 59270e8c02438425e508067aeb92da828630bdcc PiperOrigin-RevId: 613135362
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Imported from GitHub PR #9045 This is a sub PR to add SPIR target in openxla. `CudaCubinInMemory` is an object represents compiled binary for different backends. `char* bytes` is enough for cuda backend, but spir requires additional `int size` to load the binary. Copybara import of the project: -- 59270e8 by Sheng, Yang <yang.sheng@intel.com>: Add size for CudaCubinInMemory Merging this change closes #9045 FUTURE_COPYBARA_INTEGRATE_REVIEW=#9045 from Intel-tensorflow:yang/cubin 59270e8 PiperOrigin-RevId: 613135362
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 7, 2024
Imported from GitHub PR openxla/xla#9045 This is a sub PR to add SPIR target in openxla. `CudaCubinInMemory` is an object represents compiled binary for different backends. `char* bytes` is enough for cuda backend, but spir requires additional `int size` to load the binary. Copybara import of the project: -- 59270e8c02438425e508067aeb92da828630bdcc by Sheng, Yang <yang.sheng@intel.com>: Add size for CudaCubinInMemory Merging this change closes #9045 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#9045 from Intel-tensorflow:yang/cubin 59270e8c02438425e508067aeb92da828630bdcc PiperOrigin-RevId: 613135362
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 7, 2024
Imported from GitHub PR openxla/xla#9045 This is a sub PR to add SPIR target in openxla. `CudaCubinInMemory` is an object represents compiled binary for different backends. `char* bytes` is enough for cuda backend, but spir requires additional `int size` to load the binary. Copybara import of the project: -- 59270e8c02438425e508067aeb92da828630bdcc by Sheng, Yang <yang.sheng@intel.com>: Add size for CudaCubinInMemory Merging this change closes #9045 PiperOrigin-RevId: 613560214
i-chaochen
added a commit
to ROCm/xla
that referenced
this pull request
Mar 8, 2024
i-chaochen
added a commit
to ROCm/xla
that referenced
this pull request
Mar 8, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 8, 2024
…a#9045 Imported from GitHub PR openxla/xla#10350 This PR fixed a build error from openxla/xla#9045 @xla-rotation @ddunl Copybara import of the project: -- e233082e980f1d2cf74c96084472e32fa238fca9 by Chao Chen <cchen104@amd.com>: fixed CudaCubinInMemory for openxla/xla#9045 Merging this change closes #10350 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10350 from ROCm:fixed_CudaCubinInMemory e233082e980f1d2cf74c96084472e32fa238fca9 PiperOrigin-RevId: 613740970
draganmladjenovic
pushed a commit
to ROCm/xla
that referenced
this pull request
Mar 8, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 8, 2024
…a#9045 Imported from GitHub PR openxla/xla#10350 This PR fixed a build error from openxla/xla#9045 @xla-rotation @ddunl Copybara import of the project: -- e233082e980f1d2cf74c96084472e32fa238fca9 by Chao Chen <cchen104@amd.com>: fixed CudaCubinInMemory for openxla/xla#9045 Merging this change closes #10350 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10350 from ROCm:fixed_CudaCubinInMemory e233082e980f1d2cf74c96084472e32fa238fca9 PiperOrigin-RevId: 613740970
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
Imported from GitHub PR #10350 This PR fixed a build error from #9045 @xla-rotation @ddunl Copybara import of the project: -- e233082 by Chao Chen <cchen104@amd.com>: fixed CudaCubinInMemory for #9045 Merging this change closes #10350 COPYBARA_INTEGRATE_REVIEW=#10350 from ROCm:fixed_CudaCubinInMemory e233082 PiperOrigin-RevId: 613853668
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 8, 2024
…a#9045 Imported from GitHub PR openxla/xla#10350 This PR fixed a build error from openxla/xla#9045 @xla-rotation @ddunl Copybara import of the project: -- e233082e980f1d2cf74c96084472e32fa238fca9 by Chao Chen <cchen104@amd.com>: fixed CudaCubinInMemory for openxla/xla#9045 Merging this change closes #10350 PiperOrigin-RevId: 613853668
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sub PR to add SPIR target in openxla.
CudaCubinInMemoryis an object represents compiled binary for different backends.char* bytesis enough for cuda backend, but spir requires additionalint sizeto load the binary.