Add setting to disable shared spans (joins) in tracer#182
Open
timward60 wants to merge 3 commits intoopenzipkin:masterfrom
Open
Add setting to disable shared spans (joins) in tracer#182timward60 wants to merge 3 commits intoopenzipkin:masterfrom
timward60 wants to merge 3 commits intoopenzipkin:masterfrom
Conversation
Author
|
@jcchavezs You were involved with a discussions from the issue. If you have some time can you help me with this review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #125 by adding setting to disable support for joins.
When set to false, the it will force client and server spans to have different spanId's. This may be needed because zipkin traces may be reported to non-zipkin backends that might not support the concept of joining spans.