fix(remote-content): Remove MDX exceptions#129
Merged
sesheta merged 1 commit intooperate-first:masterfrom Nov 25, 2020
tumido:revert-content-exception
Merged
fix(remote-content): Remove MDX exceptions#129sesheta merged 1 commit intooperate-first:masterfrom tumido:revert-content-exception
sesheta merged 1 commit intooperate-first:masterfrom
tumido:revert-content-exception
Conversation
sesheta
added
the
size/S
Member
|
Ah, so it's only the HTML tags in those files which are treated as MDX components. |
durandom
approved these changes
Nov 25, 2020
Member
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: durandom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
cfchase
pushed a commit
that referenced
this pull request
Nov 25, 2020
quaid
pushed a commit
to quaid/operate-first.github.io-old
that referenced
this pull request
May 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: aicoe-aiops/data-science-workflows#23 operate-first/continuous-deployment#71
Reverts: operate-first/operate-first.github.io#120
Since we treat all Markdown files as MDX (while their syntax is not fully compatible) we've introduced exceptions - which makes gatsby not process certain files - files which don't comply with MDX.
MDX can't parse invalid XHTML as well as is unable to handle Markdown/HTML comments. See:
mdx-js/mdx#784
mdx-js/mdx#1039