Skip to content

Conversation

@mimotej
Copy link
Member

@mimotej mimotej commented Nov 1, 2021

Related Issues and Dependencies

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Adding kubeval to toolbox so we can use it in CI.
Part of: https://github.com/operate-first/SRE/issues/107

Description

Signed-off-by: Michal Drla <mdrla@redhat.com>
@sesheta sesheta requested a review from hemajv November 1, 2021 13:55
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 1, 2021
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2021
@sesheta
Copy link
Member

sesheta commented Nov 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021
@sesheta sesheta merged commit fc77135 into operate-first:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants