Skip to content

feat: Add kubectl and oc to toolbox #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sesheta merged 1 commit into from
Nov 15, 2021
Merged

feat: Add kubectl and oc to toolbox #56

sesheta merged 1 commit into from
Nov 15, 2021

Conversation

@mimotej
Copy link
Member

@mimotej mimotej commented Nov 15, 2021

Related Issues and Dependencies

…

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

… Explain your changes.

Description

SSIA
Resolves #53

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2021
tumido
tumido reviewed Nov 15, 2021
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2021
HumairAK
HumairAK approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@HumairAK HumairAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@HumairAK
Copy link
Member

HumairAK commented Nov 15, 2021

/hold

@sesheta sesheta added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 15, 2021
@HumairAK
Copy link
Member

HumairAK commented Nov 15, 2021

can you also update this list: https://github.com/operate-first/toolbox#tools-included

feat: Add kubectl and oc to toolbox
da2290d 
Signed-off-by: Michal Drla <mdrla@redhat.com>
@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2021
@mimotej
Copy link
Member Author

mimotej commented Nov 15, 2021 •
edited
Loading

can you also update this list: https://github.com/operate-first/toolbox#tools-included

@HumairAK I've added Kubeval, kubectl and oc to list thanks for reminder 👍

HumairAK
HumairAK approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@HumairAK HumairAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/unhold

@sesheta sesheta added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 15, 2021
@sesheta
Copy link
Member

sesheta commented Nov 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit 0f4a3c1 into operate-first:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tumido tumido tumido left review comments

@HumairAK HumairAK HumairAK approved these changes

@4n4nd 4n4nd Awaiting requested review from 4n4nd

@anishasthana anishasthana Awaiting requested review from anishasthana

@harshad16 harshad16 Awaiting requested review from harshad16

Assignees

@tumido tumido

@HumairAK HumairAK

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add oc or kubectl to toolbox

4 participants

@mimotej @HumairAK @sesheta @tumido