bumping version of the opfcli binary to v0.3.0 #66

Gregory-Pereira · 2022-03-24T20:49:21Z

Related Issues and Dependencies

Related to: operate-first/opfcli#44
Related to thoth-station/thoth-application issue 2111

This introduces a breaking change

Yes
No

This Pull Request implements

Bumping version of opfcli to new version v0.3.0 to include new onboard command.

Additional change has been included to use the https protocol instead of the unencrypted git protocol.

/cc @HumairAK

Gregory-Pereira · 2022-03-24T21:26:55Z

not sure why this failed.
/retest

HumairAK · 2022-03-25T00:37:08Z

/retest aicoe-ci/build-check

sesheta · 2022-03-25T00:37:30Z

@HumairAK: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pre-commit

Use /test all to run all jobs.

Details

In response to this:

/retest aicoe-ci/build-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

HumairAK · 2022-03-25T00:37:37Z

/retest build-check

sesheta · 2022-03-25T00:37:41Z

@HumairAK: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pre-commit

Use /test all to run all jobs.

Details

In response to this:

/retest build-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

HumairAK · 2022-03-25T00:37:59Z

/test build-check

sesheta · 2022-03-25T00:38:16Z

@HumairAK: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pre-commit

Use /test all to run all jobs.

Details

In response to this:

/test build-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

HumairAK · 2022-03-25T00:38:24Z

/test aicoe-ci/build-check

sesheta · 2022-03-25T00:38:44Z

@HumairAK: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pre-commit

Use /test all to run all jobs.

Details

In response to this:

/test aicoe-ci/build-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

HumairAK · 2022-03-25T00:39:19Z

stop fighting me sesheta
/test all

HumairAK · 2022-03-25T00:41:27Z

@harshad16 how can I attempt this build check again?

Gregory-Pereira · 2022-03-25T00:46:14Z

/test ?

sesheta · 2022-03-25T00:46:19Z

@Gregory-Pereira: The following commands are available to trigger required jobs:

/test pre-commit

Use /test all to run all jobs.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Gregory-Pereira · 2022-03-25T00:47:29Z

@HumairAK I don't think this is actually a test, my command above lists all tests and its not showing up. Also the pipeline-run succeeds but the build-check condition fails. Maybe it needs to be added to the .aicoe-ci.yaml check value?

harshad16 · 2022-03-28T16:26:19Z

/retest

harshad16 · 2022-04-14T16:50:30Z

/retest

Gregory-Pereira · 2022-04-14T17:19:27Z

/retest

larsks · 2022-04-14T20:18:44Z

The commit "bumping version of the opfcli binary to v0.3.0" seems to be doing a lot more than just bumping the version of opfcli. Maybe it should be split?

Gregory-Pereira · 2022-04-14T20:38:59Z

The commit "bumping version of the opfcli binary to v0.3.0" seems to be doing a lot more than just bumping the version of opfcli. Maybe it should be split?

Great point, I am on it. I will remove the version bump with the changes to the underlying images that make it buildable / runable.
/hold

harshad16

let not copy the labels as it make maintenance tougher.
here a suggestion that could work.

Dockerfile

Gregory-Pereira · 2022-04-21T19:52:56Z

Commits have been refactored and tests pass, ready for review @HumairAK @harshad16

harshad16

/lgtm
thanks 💯

HumairAK · 2022-04-28T23:52:24Z

/lgtm
/approve

HumairAK · 2022-04-28T23:52:34Z

/unhold

sesheta · 2022-04-28T23:52:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [HumairAK]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Gregory-Pereira requested review from 4n4nd, HumairAK and tumido as code owners March 24, 2022 20:49

sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 24, 2022

updating pre-commit git protocol to https for testing check

89bc048

Gregory-Pereira force-pushed the bump-opfcli-version-v0.3.0 branch from 343e4c4 to ebf0d4a Compare March 24, 2022 20:59

Gregory-Pereira force-pushed the bump-opfcli-version-v0.3.0 branch from ebf0d4a to 6727afd Compare April 14, 2022 17:10

sesheta added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2022

Gregory-Pereira force-pushed the bump-opfcli-version-v0.3.0 branch from 6727afd to c13cb69 Compare April 14, 2022 17:13

Gregory-Pereira force-pushed the bump-opfcli-version-v0.3.0 branch 2 times, most recently from aa1cb0d to 4f35441 Compare April 14, 2022 18:03

sesheta removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 14, 2022

sesheta added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 14, 2022

Gregory-Pereira force-pushed the bump-opfcli-version-v0.3.0 branch 2 times, most recently from cc20e53 to c472398 Compare April 14, 2022 19:55

sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2022

harshad16 requested changes Apr 18, 2022

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

Gregory-Pereira force-pushed the bump-opfcli-version-v0.3.0 branch from c472398 to c46305e Compare April 21, 2022 17:04

sesheta added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 21, 2022

Gregory-Pereira force-pushed the bump-opfcli-version-v0.3.0 branch from c46305e to d45023b Compare April 21, 2022 17:06

sesheta added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2022

Gregory-Pereira force-pushed the bump-opfcli-version-v0.3.0 branch from d45023b to e759a17 Compare April 21, 2022 17:08

Gregory-Pereira added 2 commits April 21, 2022 12:41

fixing toolbox sync_labels image usage (binary placements and labels)

414ce36

bumping opfcli version to v0.3.0

30fc776

Gregory-Pereira force-pushed the bump-opfcli-version-v0.3.0 branch from d5d88ff to 30fc776 Compare April 21, 2022 19:41

harshad16 approved these changes Apr 22, 2022

View reviewed changes

sesheta assigned harshad16 Apr 22, 2022

sesheta added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2022

sesheta assigned HumairAK Apr 28, 2022

sesheta added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 28, 2022

sesheta merged commit a225258 into operate-first:master Apr 28, 2022

bumping version of the opfcli binary to v0.3.0 #66

bumping version of the opfcli binary to v0.3.0 #66

Uh oh!

Conversation

Gregory-Pereira commented Mar 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues and Dependencies

This introduces a breaking change

This Pull Request implements

Uh oh!

Gregory-Pereira commented Mar 24, 2022

Uh oh!

HumairAK commented Mar 25, 2022

Uh oh!

sesheta commented Mar 25, 2022

Uh oh!

HumairAK commented Mar 25, 2022

Uh oh!

sesheta commented Mar 25, 2022

Uh oh!

HumairAK commented Mar 25, 2022

Uh oh!

sesheta commented Mar 25, 2022

Uh oh!

HumairAK commented Mar 25, 2022

Uh oh!

sesheta commented Mar 25, 2022

Uh oh!

HumairAK commented Mar 25, 2022

Uh oh!

HumairAK commented Mar 25, 2022

Uh oh!

Gregory-Pereira commented Mar 25, 2022

Uh oh!

sesheta commented Mar 25, 2022

Uh oh!

Gregory-Pereira commented Mar 25, 2022

Uh oh!

harshad16 commented Mar 28, 2022

Uh oh!

harshad16 commented Apr 14, 2022

Uh oh!

Gregory-Pereira commented Apr 14, 2022

Uh oh!

larsks commented Apr 14, 2022

Uh oh!

Gregory-Pereira commented Apr 14, 2022

Uh oh!

harshad16 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Gregory-Pereira commented Apr 21, 2022

Uh oh!

harshad16 left a comment

Choose a reason for hiding this comment

Uh oh!

HumairAK commented Apr 28, 2022

Uh oh!

HumairAK commented Apr 28, 2022

Uh oh!

sesheta commented Apr 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Gregory-Pereira commented Mar 24, 2022 •

edited

Loading