doc/proposals: proposal template and validator library proposal#2
Closed
estroz wants to merge 1 commit intooperator-framework:masterfrom
Closed
doc/proposals: proposal template and validator library proposal#2estroz wants to merge 1 commit intooperator-framework:masterfrom
estroz wants to merge 1 commit intooperator-framework:masterfrom
Conversation
openshift-ci-robot
requested review from
ecordell,
gallettilance and
shawn-hurley
openshift-ci-robot
added
the
size/L
Merged
Member
shawn-hurley
left a comment
shawn-hurley
left a comment
There was a problem hiding this comment.
I think this is a good start, I am just wondering if we are making it a little too complex and can make it simpler?
| type Validator interface { | ||
| // GetFuncs takes a list of arbitrary objects and returns a set of functions | ||
| // that each validate some object from the list. | ||
| GetFuncs(...interface{}) ValidatorFuncs |
Member
There was a problem hiding this comment.
Would it be simpler to deal with one object at a time? (or async) such that for a given object we get the functions and run them, may make it easier if the validateCRD func conformed to the interface instead of wrapping everything in a closure?
Would this allow for a simpler validate function code?
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc/proposals/TEMPLATE.md: proposal template, a slimmed down version of the OKD enhancement proposal templatedoc/proposals/validation-library.md: discusses a possible implementation for an extentensible validation library.Note: see the
Observations and open questionssection ofvalidation-library.mdfor discussion points./cc @gallettilance @shawn-hurley @ecordell