Skip to content

fix: alm-example parse check should not fail when the annotation if empty#215

Merged
openshift-merge-robot merged 2 commits intooperator-framework:masterfrom
camilamacedo86:fix-example-check
Jan 17, 2022
Merged

fix: alm-example parse check should not fail when the annotation if empty#215
openshift-merge-robot merged 2 commits intooperator-framework:masterfrom
camilamacedo86:fix-example-check

Conversation

@camilamacedo86
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 commented Jan 15, 2022 •
edited
Loading

Description
Fix error found using the check to test the images data.
Error "Error: Value invalid character at 0\n \u003c--(see the invalid character): invalid example" is faced when the alm-example is empty and should not.

Follow up: #207

@openshift-ci openshift-ci Bot requested review from benluddy and estroz January 15, 2022 19:33
@camilamacedo86
Copy link
Copy Markdown
Contributor Author

camilamacedo86 commented Jan 15, 2022

@dinhxuanvu, could you please give to us a hand on in this one?

@dinhxuanvu
Copy link
Copy Markdown
Member

dinhxuanvu commented Jan 15, 2022

I'm a bit confused here. I only see a yaml file. Where are the codes?

@camilamacedo86
Copy link
Copy Markdown
Contributor Author

camilamacedo86 commented Jan 16, 2022

Hi @dinhxuanvu,

Sorry, I did not push the full commit. All done now.
Could you please help us get this small fix/nit get merged?

@dinhxuanvu
Copy link
Copy Markdown
Member

dinhxuanvu commented Jan 17, 2022 •
edited
Loading

@camilamacedo86 No worries. Can you do me a favor and strip out anything that is not needed in the CSV yaml to reduce its size if possible?

@camilamacedo86
Copy link
Copy Markdown
Contributor Author

camilamacedo86 commented Jan 17, 2022

@dinhxuanvu, done 👍

dinhxuanvu
dinhxuanvu approved these changes Jan 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2022
@dinhxuanvu
Copy link
Copy Markdown
Member

dinhxuanvu commented Jan 17, 2022

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2022
@openshift-merge-robot openshift-merge-robot merged commit 77b3984 into operator-framework:master Jan 17, 2022
@camilamacedo86 camilamacedo86 deleted the fix-example-check branch January 17, 2022 13:56
This was referenced Jan 17, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

@benluddy benluddy Awaiting requested review from benluddy

@estroz estroz Awaiting requested review from estroz

Assignees

@dinhxuanvu dinhxuanvu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camilamacedo86 @dinhxuanvu @openshift-merge-robot