Substitute affinity components for affinity object#253
Merged
perdasilva merged 2 commits intooperator-framework:masterfrom Aug 1, 2022
Merged
Substitute affinity components for affinity object#253perdasilva merged 2 commits intooperator-framework:masterfrom
perdasilva merged 2 commits intooperator-framework:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
perdasilva
force-pushed
the
sub_affinity_update
branch
from
d1fc004 to
52a84df
Compare
….config (operator-framework#250)" This reverts commit f8da725.
Signed-off-by: perdasilva <perdasilva@redhat.com>
perdasilva
force-pushed
the
sub_affinity_update
branch
from
52a84df to
a810421
Compare
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: perdasilva perdasilva@redhat.com
Was thinking about this problem and came to the same conclusion as the others in the previous pull request. Better to use affinity and auto-update the api as it changes in the kube upstream.