pkg/metadata: bundle metadata utils and types#256
Closed
bcrochet wants to merge 3 commits intooperator-framework:masterfrom
Closed
pkg/metadata: bundle metadata utils and types#256bcrochet wants to merge 3 commits intooperator-framework:masterfrom
bcrochet wants to merge 3 commits intooperator-framework:masterfrom
Conversation
openshift-ci
Bot
added
the
kind/feature
bcrochet
force-pushed
the
feature/find-metadata
branch
from
966c2aa to
b374b6a
Compare
openshift-merge-robot
added
the
needs-rebase
bcrochet
force-pushed
the
feature/find-metadata
branch
from
b374b6a to
c999d46
Compare
openshift-merge-robot
removed
the
needs-rebase
bcrochet
force-pushed
the
feature/find-metadata
branch
from
c999d46 to
22599e7
Compare
openshift-merge-robot
added
the
needs-rebase
bcrochet
force-pushed
the
feature/find-metadata
branch
from
22599e7 to
f83328d
Compare
openshift-merge-robot
removed
the
needs-rebase
bcrochet
force-pushed
the
feature/find-metadata
branch
from
f83328d to
162dfd8
Compare
openshift-merge-robot
added
the
needs-rebase
added 3 commits
February 27, 2023 08:57
… in a directory and its children
and return the full AnnotationsFile from FindAnnotations() pkg/manifests: move metadata types to pkg/metadata
bcrochet
force-pushed
the
feature/find-metadata
branch
from
162dfd8 to
f18f4a7
Compare
openshift-merge-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bcrochet The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
closing as stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the original PR:
There should be a canonical set of utilities and types that can find and parse an annotations.yaml in a bundle directory instead of re-implementing that logic in various ways in various operator-framework repos. This repo is a good home for them because it is the source of truth for many OF APIs.
/kind feature
Rebase of #60