pkg/apis: add scorecard v1alpha3 API#55
Merged
estroz merged 2 commits intooperator-framework:masterfrom Jul 31, 2020
Merged
Conversation
openshift-ci-robot
requested review from
ecordell,
joelanford,
kevinrizza and
shawn-hurley
joelanford
approved these changes
Jul 29, 2020
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
A couple of questions and nits.
Otherwise
/lgtm
92 tasks
estroz
force-pushed
the
feature/scorecard-apis
branch
from
3bc5315 to
7bc9d3c
Compare
kevinrizza
reviewed
Jul 30, 2020
Member
kevinrizza
left a comment
kevinrizza
left a comment
There was a problem hiding this comment.
At a high level this seems totally reasonable. My only major question is the structure of the /pkg/ folder now. All of the OLM CRDs live in api/pkg/operators/, but now we are adding api/pkg/apis/
Should we move these apis into the operators/ folder? Or maybe move the OLM apis into their own folder in api/pkg/olm?
Member
Author
|
@kevinrizza following typical API package layout, shouldn’t OLM’s APIs be under |
Member
|
/lgtm |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
pkg/apis/scorecard/v1alpha3from operator-sdk to a central location./cc @joelanford @shawn-hurley @ecordell @kevinrizza