The example catalogd unpack failed --> "status.phase: Failing"

[emmajiafan]

Install the catalogd according to the docs/demo : https://github.com/operator-framework/catalogd/blob/main/docs/demo.gif
But the status of catalog operatorhubio failed at first , then the bundle content can be unpacked but the status is still failing.
The steps:
1.$git clone https://github.com/operator-framework/catalogd.git
2.$cd catalogd/
3.

$make kind-cluster
......
Set kubectl context to "kind-catalogd"
You can now use your cluster with:

kubectl cluster-info --context kind-catalogd

Thanks for using kind! 😊
/home/jfan/projects/src/github.com/catalogd/hack/tools/bin/kind export kubeconfig --name catalogd
Set kubectl context to "kind-catalogd"

$kubectl cluster-info --context kind-catalogd
Kubernetes control plane is running at https://127.0.0.1:46095
CoreDNS is running at https://127.0.0.1:46095/api/v1/namespaces/kube-system/services/kube-dns:dns/proxy

To further debug and diagnose cluster problems, use 'kubectl cluster-info dump'.

$make install
......
deployment.apps/catalogd-controller-manager created
kubectl wait --for=condition=Available --namespace=catalogd-system deployment/catalogd-controller-manager --timeout=60s
deployment.apps/catalogd-controller-manager condition met

$kubectl get crds -A
NAME                                           CREATED AT
bundlemetadata.catalogd.operatorframework.io   2023-05-24T07:25:58Z
catalogs.catalogd.operatorframework.io         2023-05-24T07:25:58Z
packages.catalogd.operatorframework.io         2023-05-24T07:25:58Z

$kubectl apply -f config/samples/core_v1beta1_catalog.yaml
catalog.catalogd.operatorframework.io/operatorhubio created

$kubectl get catalog -A
NAME             AGE
operatorhubio   21s

$kubectl wait --for=condition=Ready catalog operatorhubio
error: timed out waiting for the condition on catalogs/operatorhubio

$kubectl get catalog operatorhubio -o yaml
......
status:
  conditions:
  - lastTransitionTime: "2023-05-25T08:38:18Z"
    message: 'create bundle metadata objects: creating bundlemetadata "cloud-native-postgresql.v1.10.0":
      BundleMetadata.catalogd.operatorframework.io "cloud-native-postgresql.v1.10.0"
      is invalid: spec.properties[4].value: Invalid value: "string": spec.properties[4].value
      in body must be of type object: "string"'
    reason: UnpackFailed
    status: "False"
    type: Unpacked
  phase: Failing


$kubectl get catalog operatorhubio -o yaml
apiVersion: catalogd.operatorframework.io/v1beta1
kind: Catalog
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"catalogd.operatorframework.io/v1beta1","kind":"Catalog","metadata":{"annotations":{},"name":"operatorhubio"},"spec":{"source":{"image":{"ref":"quay.io/operatorhubio/catalog:latest"},"type":"image"}}}
  creationTimestamp: "2023-05-25T08:38:18Z"
  generation: 1
  name: operatorhubio
  resourceVersion: "2019"
  uid: 891f895b-4926-4fa8-aa20-92670e392783
spec:
  source:
    image:
      ref: quay.io/operatorhubio/catalog:latest
    type: image
status:
  conditions:
  - lastTransitionTime: "2023-05-25T08:38:18Z"
    message: 'create package objects: creating package "ack-acm-controller": packages.catalogd.operatorframework.io
      "ack-acm-controller" already exists'
    reason: UnpackFailed
    status: "False"
    type: Unpacked
  phase: Failing

$kubectl wait --for=condition=Ready catalog operatorhubio
error: timed out waiting for the condition on catalogs/operatorhubio

[joelanford]

@emmajiafan Thanks for the bug report!

A few things:

1. There is no Ready condition on the Catalog API. Those waits should be changed to --for=condition=Unpacked
2. Looks like we have a bug due to the type we use for property.value here. I think we may need to try changing that to json.RawMessage.
3. There's a separate known bug around handling updates and deletions of packages and bundlemetadata, captured in Enhance the logic for syncing changes to catalog contents #69