This repository was archived by the owner on Mar 3, 2025. It is now read-only.
(chore): manifests cleanup#24
Merged
anik120 merged 2 commits intooperator-framework:mainfrom Apr 10, 2023
Merged
Conversation
anik120
suggested changes
Apr 7, 2023
Member
anik120
left a comment
anik120
left a comment
There was a problem hiding this comment.
The manifest cleanup part looks good to me. Deploy target is also being fixed in #26 and it pays it a little more indepth attention to it, so we can probably leave the make deploy target cleanup part of this PR out and just leave the manifest cleanup part
Also would be nice to have a line that says
"Follow up for "
in the commit (and the first comment of the PR) so that there's a proper paper trail.
everettraven
force-pushed
the
fix/kustomize-stuff
branch
from
e302b07 to
09a572a
Compare
Collaborator
Author
|
@anik120 updated |
anik120
reviewed
Apr 10, 2023
Comment on lines
41
to
45
| # TODO(user): For common cases that do not require escalating privileges | ||
| # it is recommended to ensure that all your Pods/Containers are restrictive. | ||
| # More info: https://kubernetes.io/docs/concepts/security/pod-security-standards/#restricted | ||
| # Please uncomment the following code if your project does NOT have to work on old Kubernetes | ||
| # versions < 1.19 or on vendors versions which do NOT support this field by default (i.e. Openshift < 4.11 ). |
Member
There was a problem hiding this comment.
this todo comments feels redundant at this point
Collaborator
Author
There was a problem hiding this comment.
Cleaned up all the todos I could find and removed the old crds in 1657cb0
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
everettraven
force-pushed
the
fix/kustomize-stuff
branch
from
1657cb0 to
20e65cf
Compare
openshift-merge-robot
removed
the
needs-rebase
everettraven
changed the title
make deploy target and manifest cleanup
anik120
added a commit
to anik120/catalogd
that referenced
this pull request
Apr 11, 2023
anik120
added a commit
that referenced
this pull request
Apr 12, 2023
* run make generate as follow up to #24 * (actions) add sanity check * (Makefile) fix target tidy Tidy was being instructed to `go mod tidy` the hack/tools folder, which was being done when the tools were being downloaded using go modules (the main branch has the setup to download the tools using go installer instead) * (actions) use caching for go cmds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Some post-merge comments here: #16 (review)