This repository was archived by the owner on Mar 3, 2025. It is now read-only.
(actions): fix goreleaser/release issues#25
Merged
grokspawn merged 3 commits intooperator-framework:mainfrom Apr 11, 2023
Merged
(actions): fix goreleaser/release issues#25grokspawn merged 3 commits intooperator-framework:mainfrom
grokspawn merged 3 commits intooperator-framework:mainfrom
Conversation
Collaborator
Author
|
Since the real fix is to push a tag I think that should cut an actual release. I'm going to plan on refining the actual goreleaser release config to actually do a release. /hold |
openshift-ci
Bot
added
the
do-not-merge/hold
Collaborator
Author
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
joelanford
reviewed
Apr 7, 2023
joelanford
reviewed
Apr 7, 2023
| - id: catalogd-controller | ||
| main: ./cmd/manager/ | ||
| binary: bin/manager | ||
| tags: $GO_BUILD_TAGS |
Member
There was a problem hiding this comment.
Fine to take this out for now since we likely aren't using them, but we'll likely want to setup the infrastructure for build tags in the somewhat near future (next few months-ish) so that we can have tags like upstream and maybe e2e, and then if anyone forks this repo in a downstream, they can use a downstream tag in leiu of or in addition to the upstream tag.
joelanford
reviewed
Apr 7, 2023
joelanford
reviewed
Apr 7, 2023
everettraven
commented
Apr 7, 2023
everettraven
commented
Apr 7, 2023
Collaborator
Author
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
Holding on the need to add ldflags to build targets
/hold
openshift-ci
Bot
added
the
do-not-merge/hold
Member
I think #26 addresses this. IMO, let's keep this focused on having an actual working goreleaser setup. Any extras like this can be done in small PRs later. |
everettraven
force-pushed
the
actions/release-fix
branch
from
42d291c to
392ab99
Compare
openshift-merge-robot
added
the
needs-rebase
Closed
everettraven
force-pushed
the
actions/release-fix
branch
from
392ab99 to
15d08d8
Compare
openshift-merge-robot
removed
the
needs-rebase
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
everettraven
force-pushed
the
actions/release-fix
branch
from
c9d93db to
64cb57b
Compare
joelanford
reviewed
Apr 11, 2023
joelanford
reviewed
Apr 11, 2023
joelanford
reviewed
Apr 11, 2023
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Member
|
/lgtm |
joelanford
approved these changes
Apr 11, 2023
Collaborator
Author
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes some release action image building issues. These issues were found attempting to fix the goreleaser failure running on the main branch due to not having a tag.
Unfortunately there is not a way to fix the tag issue aside from pushing a tag so the plan as of now is to push a
v0.0.1tag once these fixes are merged and then it should work after that.