This repository was archived by the owner on Mar 3, 2025. It is now read-only.
WIP: introduce source union type#59
Closed
joelanford wants to merge 1 commit intoapi-refactorfrom
Closed
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Collaborator
|
I know it is still a work in progress, but could we break this out into a PR for each source type? As is it is quite a bit of changes to go through and I think breaking it out would allow for better reviews on each individual source implementation. |
Member
Author
|
I think we need to think about this a bit more. This is essentially copied from Rukpak, but I don't think we should have two nearly identical implementations because they will absolutely drift for no good reason. Instead, I think we should consider one or both of:
If we do either of these, we may also need to pass around an io.ReadCloser rather than an fs.FS, which is more flexible, less opinionated, and potentially more performant. |
This was referenced May 11, 2023
everettraven
added a commit
to everettraven/catalogd
that referenced
this pull request
May 17, 2023
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Member
Author
|
Closing since this was overtaken by #65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This builds upon the api-refactor branch/PR and introduces a source union type with initial implementations for:
image(I manually tested this one)httpsgitconfigMapsThis will enable catalogd to source catalog contents from a variety of sources, not just container images.